Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(559)

Issue 6462061: Merging Brian's font tool into Han-Wen's (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by yehh
Modified:
12 years, 8 months ago
Reviewers:
stuartg
CC:
bstell1
Base URL:
http://sfntly.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Merging Brian's font tool into Han-Wen's

Patch Set 1 #

Total comments: 1

Patch Set 2 : Moved 16-16 floating point to double functino to Fixed1616 class #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -513 lines) Patch
M java/src/com/google/typography/font/sfntly/math/Fixed1616.java View 1 1 chunk +8 lines, -0 lines 1 comment Download
M java/src/com/google/typography/font/tools/fontinfo/FontInfo.java View 1 20 chunks +39 lines, -129 lines 0 comments Download
M java/src/com/google/typography/font/tools/fontinfo/FontInfoMain.java View 5 chunks +6 lines, -41 lines 0 comments Download
D java/src/com/google/typography/font/tools/fontinfo/FontSummary.java View 1 chunk +0 lines, -190 lines 0 comments Download
M java/src/com/google/typography/font/tools/fontinfo/FontUtils.java View 1 1 chunk +152 lines, -3 lines 0 comments Download
D java/src/com/google/typography/font/tools/fontinfo/ReportFontSummary.java View 1 chunk +0 lines, -150 lines 0 comments Download

Messages

Total messages: 3
stuartg
LGTM - only one optional suggestion http://codereview.appspot.com/6462061/diff/1/java/src/com/google/typography/font/tools/fontinfo/FontUtils.java File java/src/com/google/typography/font/tools/fontinfo/FontUtils.java (right): http://codereview.appspot.com/6462061/diff/1/java/src/com/google/typography/font/tools/fontinfo/FontUtils.java#newcode184 java/src/com/google/typography/font/tools/fontinfo/FontUtils.java:184: public static double ...
12 years, 8 months ago (2012-08-15 18:31:32 UTC) #1
yehh
Moved 16-16 floating point to double functino to Fixed1616 class and uploaded new patch set
12 years, 8 months ago (2012-08-15 21:44:22 UTC) #2
stuartg
12 years, 8 months ago (2012-08-15 21:54:16 UTC) #3
LGTM

- other than small formatting issue

http://codereview.appspot.com/6462061/diff/4001/java/src/com/google/typograph...
File java/src/com/google/typography/font/sfntly/math/Fixed1616.java (right):

http://codereview.appspot.com/6462061/diff/4001/java/src/com/google/typograph...
java/src/com/google/typography/font/sfntly/math/Fixed1616.java:42: return
fixed/65536.0; // shift the decimal 16 bits
fixed / 65536.0
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b