Issue 6462060: Bug Fix: Fixes transformation bug where debugger locked up during incremental draw due to nested cl…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6462060: Bug Fix: Fixes transformation bug where debugger locked up during incremental draw due to nested cl… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by chudy

Modified:
12 years, 4 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Bug Fix: Fixes transformation bug where debugger locked up during incremental draw due to nested clips not being cleared. Committed: https://code.google.com/p/skia/source/detail?r=5095

Patch Set 2 : Removed deprecated comment #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	debugger/QT/SkDebuggerGUI.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	debugger/SkDebugCanvas.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DerekS

lgtm with one nit https://codereview.appspot.com/6462060/diff/4001/debugger/SkDebugCanvas.cpp File debugger/SkDebugCanvas.cpp (right): https://codereview.appspot.com/6462060/diff/4001/debugger/SkDebugCanvas.cpp#newcode93 debugger/SkDebugCanvas.cpp:93: //rect(0,0,this->fWidth,this->fHeight); remove this line

12 years, 4 months ago (2012-08-14 19:35:39 UTC) #2

chudy

12 years, 4 months ago (2012-08-14 19:39:10 UTC) #3

Committed in revision 5095. Thanks for the review

https://codereview.appspot.com/6462060/diff/4001/debugger/SkDebugCanvas.cpp
File debugger/SkDebugCanvas.cpp (right):

https://codereview.appspot.com/6462060/diff/4001/debugger/SkDebugCanvas.cpp#n...
debugger/SkDebugCanvas.cpp:93: //rect(0,0,this->fWidth,this->fHeight);
On 2012/08/14 19:35:39, DerekS wrote:
> remove this line

Done.

Expand All Messages | Collapse All Messages