Issue 6461069: remove SkShape (unused)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6461069: remove SkShape (unused) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by reed1

Modified:
12 years, 3 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

remove SkShape (unused) Committed: https://code.google.com/p/skia/source/detail?r=5033

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -755 lines)			Patch
M	gm/pathfill.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	gm/shapes.cpp	View		1 chunk	+0 lines, -124 lines	0 comments	Download
M	gyp/SampleApp.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/core.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/effects.gyp	View		4 chunks	+0 lines, -4 lines	0 comments	Download
M	gyp/gmslides.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/iOSSampleApp.gyp	View		2 chunks	+0 lines, -2 lines	0 comments	Download
D	include/core/SkShape.h	View		1 chunk	+0 lines, -49 lines	0 comments	Download
D	include/effects/SkGroupShape.h	View		1 chunk	+0 lines, -153 lines	0 comments	Download
D	include/effects/SkRectShape.h	View		1 chunk	+0 lines, -58 lines	0 comments	Download
D	samplecode/SampleShapes.cpp	View		1 chunk	+0 lines, -165 lines	0 comments	Download
D	src/core/SkShape.cpp	View		1 chunk	+0 lines, -67 lines	0 comments	Download
D	src/effects/SkGroupShape.cpp	View		1 chunk	+0 lines, -121 lines	0 comments	Download
M	src/ports/SkGlobalInitialization_default.cpp	View	1	3 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 5

DerekS

You also need to remove SkRectShape.cpp and references to shapes in SkGlobalInitialization_default.cpp

12 years, 4 months ago (2012-08-09 17:13:58 UTC) #2

lgtm! You get a gold star for deleting that much code.