code review 6461065: misc/cgo/life: explicitly specify library for assert fu...

misc/cgo/life: explicitly specify library for assert function (fixes windows/amd64 build)

[brainman, 2012-08-09 06:50:42]

Hello golang-dev@googlegroups.com (cc: minux.ma@gmail.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2012-08-09 06:56:24]

LGTM I guess, why doesn't this break on windows/386 ?

On Thu, Aug 9, 2012 at 4:50 PM,  <alex.brainman@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: minux.ma@gmail.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> misc/cgo/life: explicitly specify library for assert function (fixes
> windows/amd64 build)
>
> Please review this at http://codereview.appspot.com/6461065/
>
> Affected files:
>   M misc/cgo/life/life.go
>
>
> Index: misc/cgo/life/life.go
> ===================================================================
> --- a/misc/cgo/life/life.go
> +++ b/misc/cgo/life/life.go
> @@ -6,6 +6,7 @@
>
>  package life
>
> +// #cgo windows LDFLAGS: -lmsvcrt
>  // #include "life.h"
>  import "C"
>
>
>

[brainman, 2012-08-09 07:00:14]

On 2012/08/09 06:56:24, dfc wrote:
> ..., why doesn't this break on windows/386 ?
> 

I do not know. I do not care. :-)

Alex

[brainman, 2012-08-09 07:00:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=0934e2afdec9 ***

misc/cgo/life: explicitly specify library for assert function (fixes
windows/amd64 build)

R=golang-dev, dave
CC=golang-dev, minux.ma
http://codereview.appspot.com/6461065

[minux1, 2012-08-09 07:09:01]

LGTM.

the windows builders always surprise me.