Make ExceptionHandler::HandleSignal() public

Make ExceptionHandler::HandleSignal() public

[glider1, 2012-08-07 14:01:12]

Mark, WDYT?
I need to invoke the crash dumping mechanism from the program and abort right
after that (in my case this will be done from the ASan callback), but Breakpad
does not expose such an interface. Is it fine to just make HandleSignal()
public, or is it better to make a simpler interface that does not require
siginfo_t and ucontext from the user?

[Mark Mentovai, 2012-08-09 15:38:04]

I wouldn’t make HandleSignal public. I like the other suggestion you had in your
e-mail better: provide another interface that doesn’t require the arguments that
HandleSignal does.

[glider1, 2012-08-10 14:31:17]

Done

[Mark Mentovai, 2012-08-10 15:06:41]

LGTM

[glider1, 2012-08-10 15:35:17]

Thanks!
May I also ask you to land this patch next week?

On Fri, Aug 10, 2012 at 7:06 PM,  <mark@chromium.org> wrote:
> LGTM
>
> https://codereview.appspot.com/6461052/



-- 
Alexander Potapenko
Software Engineer
Google Moscow

[Mark Mentovai, 2012-08-10 15:41:28]

You can ask me to land it right now. r1008.

[mseaborn1, 2012-08-17 17:44:32]

The commit message for this change doesn't match the change that was committed. 
Please make sure you update commit messages.

Thanks,
Mark

[glider1, 2012-08-17 17:50:41]

Oops. Really sorry for this.
On Aug 17, 2012 9:44 PM, <mseaborn@chromium.org> wrote:

> The commit message for this change doesn't match the change that was
> committed.  Please make sure you update commit messages.
>
> Thanks,
> Mark
>
>
>
https://codereview.appspot.**com/6461052/<https://codereview.appspot.com/6461...
>