Issue 6459088: Ensure that Pipe does not crash when attempting to draw after endRecording.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6459088: Ensure that Pipe does not crash when attempting to draw after endRecording. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by Leon

Modified:
12 years, 1 month ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Ensure that Pipe does not crash when attempting to draw after endRecording. Add a test for drawing a bitmap and a bitmapshader after endRecording. BUG=https://code.google.com/p/skia/issues/detail?id=774&can=3 Test=PipeTest Committed: https://code.google.com/p/skia/source/detail?r=5099

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -10 lines)			Patch
	M	src/pipe/SkGPipeWrite.cpp	View	1	5 chunks	+11 lines, -7 lines	0 comments	Download
	M	tests/PipeTest.cpp	View		2 chunks	+29 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DerekS

lgtm with a few nits https://codereview.appspot.com/6459088/diff/1/src/pipe/SkGPipeWrite.cpp File src/pipe/SkGPipeWrite.cpp (right): https://codereview.appspot.com/6459088/diff/1/src/pipe/SkGPipeWrite.cpp#newcode195 src/pipe/SkGPipeWrite.cpp:195: return NULL == fBitmapHeap ...

12 years, 1 month ago (2012-08-14 20:31:38 UTC) #2

Leon

12 years, 1 month ago (2012-08-14 20:38:11 UTC) #3

https://codereview.appspot.com/6459088/diff/1/src/pipe/SkGPipeWrite.cpp
File src/pipe/SkGPipeWrite.cpp (right):

https://codereview.appspot.com/6459088/diff/1/src/pipe/SkGPipeWrite.cpp#newco...
src/pipe/SkGPipeWrite.cpp:195: return NULL == fBitmapHeap ? 0 :
fBitmapHeap->bytesAllocated();
On 2012/08/14 20:31:39, DerekS wrote:
> can you add parenthesis here to make the order of operation clear?

Done.

https://codereview.appspot.com/6459088/diff/1/src/pipe/SkGPipeWrite.cpp#newco...
src/pipe/SkGPipeWrite.cpp:945: return NULL == fBitmapHeap ? 0 :
fBitmapHeap->freeMemoryIfPossible(bytesToFree);
On 2012/08/14 20:31:39, DerekS wrote:
> same

Done.

Expand All Messages | Collapse All Messages