Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 6459055: code review 6459055: proxy: fix wrong function name in comment (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by agl1
Modified:
12 years, 7 months ago
Reviewers:
CC:
golang-dev, minux1
Visibility:
Public.

Description

proxy: fix wrong function name in comment

Patch Set 1 #

Patch Set 2 : diff -r d7d24fafd03c https://agl%40golang.org@code.google.com/p/go.net/ #

Patch Set 3 : diff -r d7d24fafd03c https://agl%40golang.org@code.google.com/p/go.net/ #

Total comments: 2

Patch Set 4 : diff -r d7d24fafd03c https://agl%40golang.org@code.google.com/p/go.net/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M proxy/per_host.go View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://agl%40golang.org@code.google.com/p/go.net/
12 years, 7 months ago (2012-08-07 16:04:37 UTC) #1
minux1
also: comment in line 27 of proxy.go is wrong. http://codereview.appspot.com/6459055/diff/1002/proxy/per_host.go File proxy/per_host.go (right): http://codereview.appspot.com/6459055/diff/1002/proxy/per_host.go#newcode35 proxy/per_host.go:35: ...
12 years, 7 months ago (2012-08-07 16:11:36 UTC) #2
agl1
12 years, 7 months ago (2012-08-14 01:29:10 UTC) #3
*** Submitted as
http://code.google.com/p/go/source/detail?r=147c4a6dca9b&repo=net ***

proxy: fix wrong function name in comment

R=golang-dev, minux.ma
CC=golang-dev
http://codereview.appspot.com/6459055

http://codereview.appspot.com/6459055/diff/1002/proxy/per_host.go
File proxy/per_host.go (right):

http://codereview.appspot.com/6459055/diff/1002/proxy/per_host.go#newcode35
proxy/per_host.go:35: func (p *PerHost) Dial(network, addr string) (c net.Conn,
err error) {
On 2012/08/07 16:11:36, minux wrote:
> i think this comment mentions network "net", but the code uses "networks".
> should this be made consistent?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b