Issue 6459054: code review 6459054: exp/html: foster-parent text correctly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6459054: code review 6459054: exp/html: foster-parent text correctly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by andybalholm

Modified:
12 years, 8 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

exp/html: foster-parent text correctly If a table contained whitespace, text nodes would not get foster parented correctly. Pass 1 additional test.

Patch Set 2 : diff -r 4e3a1967af09 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4e3a1967af09 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
	M	src/pkg/exp/html/parse.go	View	1	3 chunks	+23 lines, -10 lines	1 comment	Download
	M	src/pkg/exp/html/testlogs/tests7.dat.log	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 8 months ago (2012-08-07 15:08:46 UTC) #1

nigeltao

LGTM. Submitting... http://codereview.appspot.com/6459054/diff/4001/src/pkg/exp/html/parse.go File src/pkg/exp/html/parse.go (right): http://codereview.appspot.com/6459054/diff/4001/src/pkg/exp/html/parse.go#newcode222 src/pkg/exp/html/parse.go:222: // shouldFosterParent returns true if the next ...

12 years, 8 months ago (2012-08-07 23:59:44 UTC) #2

nigeltao

12 years, 8 months ago (2012-08-08 00:01:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b562c975ab22 ***

exp/html: foster-parent text correctly

If a table contained whitespace, text nodes would not get foster parented
correctly.

Pass 1 additional test.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/6459054

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages