Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 6458109: update webapp2 to use webob 1.2.2

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by proppy
Modified:
13 years, 1 month ago
Reviewers:
rodrigo.moraes, sammc
Visibility:
Public.

Description

update webapp2 to use webob 1.2.2

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24475 lines, -21404 lines) Patch
M docs/conf.py View 1 chunk +1 line, -1 line 0 comments Download
R lib/WebOb-1.0.8/MANIFEST.in View 1 1 chunk +0 lines, -4 lines 0 comments Download
R lib/WebOb-1.0.8/PKG-INFO View 1 1 chunk +0 lines, -37 lines 0 comments Download
R lib/WebOb-1.0.8/docs/comment-example.txt View 1 1 chunk +0 lines, -414 lines 0 comments Download
R lib/WebOb-1.0.8/docs/comment-example-code/example.py View 1 1 chunk +0 lines, -150 lines 0 comments Download
R lib/WebOb-1.0.8/docs/conf.py View 1 1 chunk +0 lines, -132 lines 0 comments Download
R lib/WebOb-1.0.8/docs/differences.txt View 1 1 chunk +0 lines, -698 lines 0 comments Download
R lib/WebOb-1.0.8/docs/do-it-yourself.txt View 1 1 chunk +0 lines, -581 lines 0 comments Download
R lib/WebOb-1.0.8/docs/doctests.py View 1 1 chunk +0 lines, -17 lines 0 comments Download
R lib/WebOb-1.0.8/docs/file-example.txt View 1 1 chunk +0 lines, -214 lines 0 comments Download
R lib/WebOb-1.0.8/docs/index.txt View 1 1 chunk +0 lines, -337 lines 0 comments Download
R lib/WebOb-1.0.8/docs/jsonrpc-example.txt View 1 1 chunk +0 lines, -657 lines 0 comments Download
R lib/WebOb-1.0.8/docs/jsonrpc-example-code/jsonrpc.py View 1 1 chunk +0 lines, -193 lines 0 comments Download
R lib/WebOb-1.0.8/docs/jsonrpc-example-code/test_jsonrpc.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
R lib/WebOb-1.0.8/docs/jsonrpc-example-code/test_jsonrpc.txt View 1 1 chunk +0 lines, -27 lines 0 comments Download
R lib/WebOb-1.0.8/docs/license.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
R lib/WebOb-1.0.8/docs/modules/dec.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
R lib/WebOb-1.0.8/docs/modules/webob.txt View 1 1 chunk +0 lines, -75 lines 0 comments Download
R lib/WebOb-1.0.8/docs/news.txt View 1 1 chunk +0 lines, -657 lines 0 comments Download
R lib/WebOb-1.0.8/docs/pycon2011/pycon-py3k-sprint.txt View 1 1 chunk +0 lines, -75 lines 0 comments Download
R lib/WebOb-1.0.8/docs/pycon2011/request_table.rst View 1 1 chunk +0 lines, -145 lines 0 comments Download
R lib/WebOb-1.0.8/docs/pycon2011/response_table.rst View 1 1 chunk +0 lines, -68 lines 0 comments Download
R lib/WebOb-1.0.8/docs/reference.txt View 1 1 chunk +0 lines, -1028 lines 0 comments Download
R lib/WebOb-1.0.8/docs/test-file.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
R lib/WebOb-1.0.8/docs/test_dec.txt View 1 1 chunk +0 lines, -103 lines 0 comments Download
R lib/WebOb-1.0.8/docs/test_request.txt View 1 1 chunk +0 lines, -558 lines 0 comments Download
R lib/WebOb-1.0.8/docs/test_response.txt View 1 1 chunk +0 lines, -446 lines 0 comments Download
R lib/WebOb-1.0.8/docs/wiki-example.txt View 1 1 chunk +0 lines, -696 lines 0 comments Download
R lib/WebOb-1.0.8/docs/wiki-example-code/example.py View 1 1 chunk +0 lines, -200 lines 0 comments Download
R lib/WebOb-1.0.8/setup.cfg View 1 1 chunk +0 lines, -14 lines 0 comments Download
R lib/WebOb-1.0.8/setup.py View 1 1 chunk +0 lines, -50 lines 0 comments Download
R lib/WebOb-1.0.8/tests/__init__.py View 1 1 chunk +0 lines, -1 line 0 comments Download
R lib/WebOb-1.0.8/tests/conftest.py View 1 1 chunk +0 lines, -4 lines 0 comments Download
R lib/WebOb-1.0.8/tests/performance_test.py View 1 1 chunk +0 lines, -50 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_acceptparse.py View 1 1 chunk +0 lines, -345 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_byterange.py View 1 1 chunk +0 lines, -231 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_cachecontrol.py View 1 1 chunk +0 lines, -266 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_cookies.py View 1 1 chunk +0 lines, -128 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_datetime_utils.py View 1 1 chunk +0 lines, -116 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_dec.py View 1 1 chunk +0 lines, -267 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_descriptors.py View 1 1 chunk +0 lines, -797 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_etag.py View 1 1 chunk +0 lines, -451 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_exc.py View 1 1 chunk +0 lines, -360 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_headers.py View 1 1 chunk +0 lines, -113 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_in_wsgiref.py View 1 1 chunk +0 lines, -69 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_misc.py View 1 1 chunk +0 lines, -163 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_multidict.py View 1 1 chunk +0 lines, -410 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_request.py View 1 1 chunk +0 lines, -2403 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_request_nose.py View 1 1 chunk +0 lines, -60 lines 0 comments Download
R lib/WebOb-1.0.8/tests/test_response.py View 1 1 chunk +0 lines, -1035 lines 0 comments Download
R lib/WebOb-1.0.8/webob/__init__.py View 1 1 chunk +0 lines, -45 lines 0 comments Download
R lib/WebOb-1.0.8/webob/acceptparse.py View 1 1 chunk +0 lines, -359 lines 0 comments Download
R lib/WebOb-1.0.8/webob/byterange.py View 1 1 chunk +0 lines, -238 lines 0 comments Download
R lib/WebOb-1.0.8/webob/cachecontrol.py View 1 1 chunk +0 lines, -227 lines 0 comments Download
R lib/WebOb-1.0.8/webob/cookies.py View 1 1 chunk +0 lines, -198 lines 0 comments Download
R lib/WebOb-1.0.8/webob/datetime_utils.py View 1 1 chunk +0 lines, -99 lines 0 comments Download
R lib/WebOb-1.0.8/webob/dec.py View 1 1 chunk +0 lines, -358 lines 0 comments Download
R lib/WebOb-1.0.8/webob/descriptors.py View 1 1 chunk +0 lines, -294 lines 0 comments Download
R lib/WebOb-1.0.8/webob/etag.py View 1 1 chunk +0 lines, -239 lines 0 comments Download
R lib/WebOb-1.0.8/webob/exc.py View 1 1 chunk +0 lines, -1087 lines 0 comments Download
R lib/WebOb-1.0.8/webob/headers.py View 1 1 chunk +0 lines, -147 lines 0 comments Download
R lib/WebOb-1.0.8/webob/multidict.py View 1 1 chunk +0 lines, -634 lines 0 comments Download
R lib/WebOb-1.0.8/webob/request.py View 1 1 chunk +0 lines, -1323 lines 0 comments Download
R lib/WebOb-1.0.8/webob/response.py View 1 1 chunk +0 lines, -1183 lines 0 comments Download
R lib/WebOb-1.0.8/webob/util.py View 1 1 chunk +0 lines, -70 lines 0 comments Download
A lib/WebOb-1.2.2/MANIFEST.in View 1 chunk +4 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/PKG-INFO View 1 chunk +37 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/comment-example.txt View 1 chunk +414 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/comment-example-code/example.py View 1 chunk +147 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/conf.py View 1 chunk +37 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/differences.txt View 1 chunk +697 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/do-it-yourself.txt View 1 chunk +580 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/doctests.py View 1 chunk +17 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/file-example.txt View 1 chunk +224 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/index.txt View 1 chunk +336 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/jsonrpc-example.txt View 1 chunk +653 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/jsonrpc-example-code/jsonrpc.py View 1 chunk +193 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/jsonrpc-example-code/test_jsonrpc.py View 1 chunk +3 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/jsonrpc-example-code/test_jsonrpc.txt View 1 chunk +27 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/license.txt View 1 chunk +23 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/modules/client.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/modules/dec.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/modules/static.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/modules/webob.txt View 1 chunk +93 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/news.txt View 1 chunk +998 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/pycon2011/pycon-py3k-sprint.txt View 1 chunk +75 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/pycon2011/request_table.rst View 1 chunk +145 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/pycon2011/response_table.rst View 1 chunk +68 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/reference.txt View 1 chunk +999 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/test-file.txt View 1 chunk +1 line, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/test_dec.txt View 1 chunk +103 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/test_request.txt View 1 chunk +544 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/test_response.txt View 1 chunk +445 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/wiki-example.txt View 1 chunk +687 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/docs/wiki-example-code/example.py View 1 chunk +200 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/setup.cfg View 1 chunk +16 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/setup.py View 1 chunk +58 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/conftest.py View 1 chunk +4 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/performance_test.py View 1 chunk +50 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_acceptparse.py View 1 chunk +326 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_byterange.py View 1 chunk +102 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_cachecontrol.py View 1 chunk +266 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_client.py View 1 chunk +241 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_client_functional.py View 1 chunk +98 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_compat.py View 1 chunk +49 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_cookies.py View 1 chunk +333 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_datetime_utils.py View 1 chunk +128 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_dec.py View 1 chunk +213 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_descriptors.py View 1 chunk +761 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_etag.py View 1 chunk +172 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_etag_nose.py View 1 chunk +70 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_exc.py View 1 chunk +352 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_headers.py View 1 chunk +113 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_in_wsgiref.py View 1 chunk +188 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_misc.py View 1 chunk +136 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_multidict.py View 1 chunk +397 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_request.py View 1 chunk +3549 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_request_nose.py View 1 chunk +191 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_response.py View 1 chunk +1031 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_static.py View 1 chunk +241 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_transcode.py View 1 chunk +78 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/tests/test_util.py View 1 chunk +44 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/__init__.py View 1 chunk +13 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/acceptparse.py View 1 chunk +339 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/byterange.py View 1 chunk +160 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/cachecontrol.py View 1 chunk +229 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/client.py View 1 chunk +182 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/compat.py View 1 chunk +131 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/cookies.py View 1 chunk +370 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/datetime_utils.py View 1 chunk +117 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/dec.py View 1 chunk +299 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/descriptors.py View 1 chunk +339 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/etag.py View 1 chunk +189 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/exc.py View 1 chunk +1139 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/headers.py View 1 chunk +158 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/multidict.py View 1 chunk +494 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/request.py View 1 chunk +1720 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/response.py View 1 chunk +1291 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/static.py View 1 chunk +168 lines, -0 lines 0 comments Download
A lib/WebOb-1.2.2/webob/util.py View 1 chunk +132 lines, -0 lines 0 comments Download
M requirements.pip View 1 chunk +1 line, -1 line 0 comments Download
M run_tests.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/request_test.py View 5 chunks +8 lines, -16 lines 0 comments Download
M tests/webapp1_test.py View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6
proppy
Please review this patch that update webapp2 test suite to work with webob 1.2.2.
13 years, 1 month ago (2012-08-10 12:23:38 UTC) #1
sammc
Any reason for keeping webob 1.0.8 in lib? http://codereview.appspot.com/6458109/diff/1/run_tests.py File run_tests.py (right): http://codereview.appspot.com/6458109/diff/1/run_tests.py#newcode5 run_tests.py:5: gae_path ...
13 years, 1 month ago (2012-08-13 06:59:19 UTC) #2
proppy
PTAL http://codereview.appspot.com/6458109/diff/1/run_tests.py File run_tests.py (right): http://codereview.appspot.com/6458109/diff/1/run_tests.py#newcode5 run_tests.py:5: gae_path = '/usr/local/google/home/proppy/google_appengine' On 2012/08/13 06:59:19, sammc wrote: ...
13 years, 1 month ago (2012-08-13 09:34:43 UTC) #3
sammc
LGTM
13 years, 1 month ago (2012-08-13 23:53:10 UTC) #4
proppy
can someone with commit access submit this CL? On Tue, Aug 14, 2012 at 1:53 ...
13 years, 1 month ago (2012-08-14 08:17:08 UTC) #5
rodrigo.moraes
13 years, 1 month ago (2012-08-14 10:57:23 UTC) #6
On 2012/08/14 08:17:08, proppy wrote:
> can someone with commit access submit this CL?

Done. Thank you, proppy.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b