Refactored the bitmap creation into PictureRenderer.

Refactored the bitmap creation into PictureRenderer.

Further, the picture is also stored in the PictureRenderer.

The main gain of all of this is that we will not have to change how the device in more than one place when we end up adding different devices.

Committed https://code.google.com/p/skia/source/detail?r=4990

[junov1, 2012-08-06 14:17:41]

https://codereview.appspot.com/6458074/diff/2001/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (right):

https://codereview.appspot.com/6458074/diff/2001/tools/PictureRenderer.cpp#ne...
tools/PictureRenderer.cpp:27: sk_tools::setup_bitmap(&bitmap,
fPicture.get()->width(), fPicture.get()->height());
No need to call get() all the time. fPicture->width() will work just fine. 
They're called smart pointers because you can use them as if they were pointers.
 only call get() if you specifically need a dumb pointer.

https://codereview.appspot.com/6458074/diff/2001/tools/PictureRenderer.cpp#ne...
tools/PictureRenderer.cpp:32: SkASSERT(fCanvas.get() != NULL);
Here for example, calling get() makes sense.

https://codereview.appspot.com/6458074/diff/2001/tools/PictureRenderer.cpp#ne...
tools/PictureRenderer.cpp:45: void SimplePictureRenderer::render() {
Why no assert here?

https://codereview.appspot.com/6458074/diff/2001/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (right):

https://codereview.appspot.com/6458074/diff/2001/tools/bench_pictures_main.cp...
tools/bench_pictures_main.cpp:62: SkPicture* picture = SkNEW_ARGS(SkPicture,
(&inputStream));
Could make this an SkAutoTUnref, and get rid of the unref at the end of this
func.

Also, why does this need to be dynamically allocated?

https://codereview.appspot.com/6458074/diff/2001/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6458074/diff/2001/tools/render_pictures_main.c...
tools/render_pictures_main.cpp:96: SkPicture* picture = SkNEW_ARGS(SkPicture,
(&inputStream));
Why does this need to be dynamically allocated?

[keyar, 2012-08-06 20:02:37]

Updated to reflect reviewers wishes plus some style issues I noticed.

[junov1, 2012-08-06 20:14:56]

On 2012/08/06 20:02:37, keyar wrote:
> Updated to reflect reviewers wishes plus some style issues I noticed.

lgtm