Issue 6458065: Move morphology GPU implementation into SkMorphologyimageFilter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6458065: Move morphology GPU implementation into SkMorphologyimageFilter (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by Stephen White

Modified:
11 years, 10 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

This is (as much as possible) a straight code move from GrContext and GrMorphologyEffect.* into SkMorphologyImageFilter.cpp.

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+270 lines, -327 lines)			Patch
M	gyp/gpu.gyp	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	include/effects/SkMorphologyImageFilter.h	View	1 2	3 chunks	+6 lines, -0 lines	0 comments	Download
M	include/gpu/GrContext.h	View	1 2	1 chunk	+0 lines, -26 lines	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View	1 2	2 chunks	+264 lines, -16 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 2	3 chunks	+0 lines, -66 lines	0 comments	Download
D	src/gpu/effects/GrMorphologyEffect.h	View	1 2	1 chunk	+0 lines, -49 lines	0 comments	Download
D	src/gpu/effects/GrMorphologyEffect.cpp	View	1 2	1 chunk	+0 lines, -168 lines	0 comments	Download

Total messages: 5

bsalomon

Overall looks good. Two things: 1) Should we have a mechanism for the SkGpuDevice to ...

11 years, 11 months ago (2012-08-02 14:21:58 UTC) #2

bsalomon

LGTM. Do you think we need something like onFilterImageGPU() for SkMaskFilter so that we can ...

11 years, 10 months ago (2012-08-22 19:55:01 UTC) #3

Stephen White

On 2012/08/22 19:55:01, bsalomon wrote: > LGTM. Do you think we need something like onFilterImageGPU() ...

11 years, 10 months ago (2012-08-22 20:01:17 UTC) #4

Landed as r5241; closing.