Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6935)

Issue 6458065: Move morphology GPU implementation into SkMorphologyimageFilter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by Stephen White
Modified:
12 years, 3 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This is (as much as possible) a straight code move from GrContext and GrMorphologyEffect.* into SkMorphologyImageFilter.cpp.

Patch Set 1 #

Patch Set 2 : Remove an extraneous include #

Patch Set 3 : updated to ToT; moved from GrDrawTarget to GrContext calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -327 lines) Patch
M gyp/gpu.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 2 chunks +264 lines, -16 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 chunks +0 lines, -66 lines 0 comments Download
D src/gpu/effects/GrMorphologyEffect.h View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
D src/gpu/effects/GrMorphologyEffect.cpp View 1 2 1 chunk +0 lines, -168 lines 0 comments Download

Messages

Total messages: 5
Stephen White
12 years, 4 months ago (2012-08-01 22:09:12 UTC) #1
bsalomon
Overall looks good. Two things: 1) Should we have a mechanism for the SkGpuDevice to ...
12 years, 4 months ago (2012-08-02 14:21:58 UTC) #2
bsalomon
LGTM. Do you think we need something like onFilterImageGPU() for SkMaskFilter so that we can ...
12 years, 3 months ago (2012-08-22 19:55:01 UTC) #3
Stephen White
On 2012/08/22 19:55:01, bsalomon wrote: > LGTM. Do you think we need something like onFilterImageGPU() ...
12 years, 3 months ago (2012-08-22 20:01:17 UTC) #4
Stephen White
12 years, 3 months ago (2012-08-22 21:31:52 UTC) #5
Landed as r5241; closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b