Fix skdiff when using windows path that begins with a drive letter

[bsalomon, 2012-07-30 18:24:57]

I run skdiff d:\src\pre d:\src\post d:\src\comp and it doesn't work. The html
has "..\..\d:\" in the file names.

[EricB, 2012-07-30 18:34:21]

On 2012/07/30 18:24:57, bsalomon wrote:
> I run skdiff d:\src\pre d:\src\post d:\src\comp and it doesn't work. The html
> has "..\..\d:\" in the file names.

I think this is okay for a temporary fix, but it would be nice to make it handle
absolute paths on all platforms.  I'm not sure what the future of skdiff is,
though.

[EricB, 2012-07-30 18:34:44]

http://codereview.appspot.com/6458046/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

http://codereview.appspot.com/6458046/diff/1/tools/skdiff_main.cpp#newcode1054
tools/skdiff_main.cpp:1054: // Should this check if the path starts with a '/'?
probably so.

http://codereview.appspot.com/6458046/diff/1/tools/skdiff_main.cpp#newcode1055
tools/skdiff_main.cpp:1055: pathFromRoot = false;
"bool pathFromRoot = false"

[bsalomon, 2012-07-30 19:08:02]

updated

http://codereview.appspot.com/6458046/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

http://codereview.appspot.com/6458046/diff/1/tools/skdiff_main.cpp#newcode1054
tools/skdiff_main.cpp:1054: // Should this check if the path starts with a '/'?
On 2012/07/30 18:34:44, EricB wrote:
> probably so.

Done.

http://codereview.appspot.com/6458046/diff/1/tools/skdiff_main.cpp#newcode1055
tools/skdiff_main.cpp:1055: pathFromRoot = false;
On 2012/07/30 18:34:44, EricB wrote:
> "bool pathFromRoot = false"

Done.

[EricB, 2012-07-30 19:12:31]

On 2012/07/30 19:08:02, bsalomon wrote:
> updated
> 
> http://codereview.appspot.com/6458046/diff/1/tools/skdiff_main.cpp
> File tools/skdiff_main.cpp (right):
> 
> http://codereview.appspot.com/6458046/diff/1/tools/skdiff_main.cpp#newcode1054
> tools/skdiff_main.cpp:1054: // Should this check if the path starts with a
'/'?
> On 2012/07/30 18:34:44, EricB wrote:
> > probably so.
> 
> Done.
> 
> http://codereview.appspot.com/6458046/diff/1/tools/skdiff_main.cpp#newcode1055
> tools/skdiff_main.cpp:1055: pathFromRoot = false;
> On 2012/07/30 18:34:44, EricB wrote:
> > "bool pathFromRoot = false"
> 
> Done.

LGTM @ patch set 2.

[TomH, 2012-07-30 19:32:18]

LGTM

[bsalomon, 2012-07-30 19:33:24]

Landed as r4838. I wonder if there is some smart path handling library that
abstracts the windows / unix differences that we should be using. skdiff path
handling is a collection of hacks.

[epoger, 2012-08-07 19:44:52]

Followup change out for review as https://codereview.appspot.com/6450106/
('skdiff: clean up isPathAbsolute check for Windows')

I think the right long-term direction is to replace much of skdiff with a Python
script, so we can take advantage of Python's much better path handling and
whatnot.  Probably still using some native code deep inside, to actually do the
image comparisons...