Issue 6457089: Add convenience constructor for DateTime

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6457089: Add convenience constructor for DateTime (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by rmistry

Modified:
13 years, 3 months ago

Reviewers:
yanivi

Base URL:
https://google-http-java-client.googlecode.com/hg/

Visibility:
Public.

Description

Related to http://code.google.com/p/google-api-java-client/issues/detail?id=583 : Use DateValue objects for "date" values.

Patch Set 2 : review comments #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	google-http-client/src/main/java/com/google/api/client/util/DateTime.java	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
	M	google-http-client/src/test/java/com/google/api/client/util/DateTimeTest.java	View		2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

yanivi

LGTM http://codereview.appspot.com/6457089/diff/1/google-http-client/src/main/java/com/google/api/client/util/DateTime.java File google-http-client/src/main/java/com/google/api/client/util/DateTime.java (right): http://codereview.appspot.com/6457089/diff/1/google-http-client/src/main/java/com/google/api/client/util/DateTime.java#newcode85 google-http-client/src/main/java/com/google/api/client/util/DateTime.java:85: * Instantiates {@link DateTime} from an RFC 3339 ...

13 years, 3 months ago (2012-08-16 20:07:04 UTC) #2

rmistry

13 years, 3 months ago (2012-08-17 12:00:01 UTC) #3

http://codereview.appspot.com/6457089/diff/1/google-http-client/src/main/java...
File google-http-client/src/main/java/com/google/api/client/util/DateTime.java
(right):

http://codereview.appspot.com/6457089/diff/1/google-http-client/src/main/java...
google-http-client/src/main/java/com/google/api/client/util/DateTime.java:85: *
Instantiates {@link DateTime} from an RFC 3339 date/time value.
On 2012/08/16 20:07:04, yanivi wrote:
> please refrence link http://tools.ietf.org/html/rfc3339

Done.

http://codereview.appspot.com/6457089/diff/1/google-http-client/src/main/java...
google-http-client/src/main/java/com/google/api/client/util/DateTime.java:90:
DateTime dateTime = parseRfc3339(value);
On 2012/08/16 20:07:04, yanivi wrote:
> A more elegant implementation would be to move the implementation of
> parseRfc3339 into the constructor and have the implementation of parseRfc3339
> instead be simply "return new DateTime(str);".  But this is too minor, so for
> now a simple TODO would suffice.

Done.

Expand All Messages | Collapse All Messages