Fix testcase failure when IBus is not installed.

Fix testcase failure when IBus is not installed.


BUG=none

[Daiki Ueno, 2012-08-01 09:32:52]

This is a first try of making tests not depend on installed components.  While
the main idea is the wrapper script "setupenv" which runs ibus-daemon from the
builddir, IBUS_COMPONENT_PATH is also added to the core so ibus-daemon can
launch config and engine components from the builddir.

[Daiki Ueno, 2012-08-02 06:49:38]

On 2012/08/01 09:32:52, Daiki Ueno wrote:
> This is a first try of making tests not depend on installed components.  While
> the main idea is the wrapper script "setupenv" which runs ibus-daemon from the
> builddir, IBUS_COMPONENT_PATH is also added to the core so ibus-daemon can
> launch config and engine components from the builddir.

The first CL works but with the second CL (removed wait for ibus-daemon
startup), ibus-config test sometimes fails because configuration daemon is not
yet started when IBUS_ADDRESS_FILE is written.

Maybe good to delay writing IBUS_ADDRESS_FILE until config daemon is started. 
What do you think?

[Peng, 2012-08-02 14:58:45]

https://codereview.appspot.com/6455068/diff/1004/src/tests/Makefile.am
File src/tests/Makefile.am (right):

https://codereview.appspot.com/6455068/diff/1004/src/tests/Makefile.am#newcode58
src/tests/Makefile.am:58: $(builddir)/setupenv
Please add a new line with $(NULL)

https://codereview.appspot.com/6455068/diff/1004/src/tests/setupenv
File src/tests/setupenv (right):

https://codereview.appspot.com/6455068/diff/1004/src/tests/setupenv#newcode44
src/tests/setupenv:44: "$@"
Is it necessary to clean all temporary files?
I remember make distcheck will check if all temporary files are cleaned. Please
try make distcheck.

[Daiki Ueno, 2012-08-03 07:02:14]

https://codereview.appspot.com/6455068/diff/1004/src/tests/Makefile.am
File src/tests/Makefile.am (right):

https://codereview.appspot.com/6455068/diff/1004/src/tests/Makefile.am#newcode58
src/tests/Makefile.am:58: $(builddir)/setupenv
On 2012/08/02 14:58:45, Peng wrote:
> Please add a new line with $(NULL)

Done.

https://codereview.appspot.com/6455068/diff/1004/src/tests/setupenv
File src/tests/setupenv (right):

https://codereview.appspot.com/6455068/diff/1004/src/tests/setupenv#newcode27
src/tests/setupenv:27: copy_component "$top_srcdir/conf/memconf/memconf.xml"
BTW, for testing purpose memconf is very helpful among others (since it does not
save values to disk and not require dbus session).  How about enabling it by
default?

https://codereview.appspot.com/6455068/diff/1004/src/tests/setupenv#newcode44
src/tests/setupenv:44: "$@"
On 2012/08/02 14:58:45, Peng wrote:
> Is it necessary to clean all temporary files?
> I remember make distcheck will check if all temporary files are cleaned.
Please
> try make distcheck.

temp files should be cleaned with "trap" above.

[Peng, 2012-08-03 13:57:47]

On 2012/08/03 07:02:14, Daiki Ueno wrote:
> https://codereview.appspot.com/6455068/diff/1004/src/tests/Makefile.am
> File src/tests/Makefile.am (right):
> 
>
https://codereview.appspot.com/6455068/diff/1004/src/tests/Makefile.am#newcode58
> src/tests/Makefile.am:58: $(builddir)/setupenv
> On 2012/08/02 14:58:45, Peng wrote:
> > Please add a new line with $(NULL)
> 
> Done.
> 
> https://codereview.appspot.com/6455068/diff/1004/src/tests/setupenv
> File src/tests/setupenv (right):
> 
> https://codereview.appspot.com/6455068/diff/1004/src/tests/setupenv#newcode27
> src/tests/setupenv:27: copy_component "$top_srcdir/conf/memconf/memconf.xml"
> BTW, for testing purpose memconf is very helpful among others (since it does
not
> save values to disk and not require dbus session).  How about enabling it by
> default?
> 
> https://codereview.appspot.com/6455068/diff/1004/src/tests/setupenv#newcode44
> src/tests/setupenv:44: "$@"
> On 2012/08/02 14:58:45, Peng wrote:
> > Is it necessary to clean all temporary files?
> > I remember make distcheck will check if all temporary files are cleaned.
> Please
> > try make distcheck.
> 
> temp files should be cleaned with "trap" above.

I see. Thanks. LGTM

[Daiki Ueno, 2012-08-06 01:27:55]

Sorry, just noticed that make check fails when IBus is running.
I'll soon update the CL to address that.

[Daiki Ueno, 2012-08-08 03:58:59]

On 2012/08/06 01:27:55, Daiki Ueno wrote:
> Sorry, just noticed that make check fails when IBus is running.
> I'll soon update the CL to address that.

OK, that was because system default config daemon is used - CL4 should fix this
by using ibus-memconf only.  I'll commit this soon if no objection.