Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(603)

Issue 6454117: code review 6454117: misc/dashboard/codereview: fixes for non-reviewers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by dsymonds
Modified:
12 years, 7 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

misc/dashboard/codereview: fixes for non-reviewers. Also rename the testing CGI argument from "email" to "user".

Patch Set 1 #

Patch Set 2 : diff -r b562c975ab22 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b562c975ab22 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4738fd47e7a9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M misc/dashboard/codereview/dashboard/front.go View 1 4 chunks +18 lines, -11 lines 0 comments Download
M misc/dashboard/codereview/index.yaml View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dsymonds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 7 months ago (2012-08-08 01:06:29 UTC) #1
r
LGTM
12 years, 7 months ago (2012-08-08 03:07:38 UTC) #2
dsymonds
12 years, 7 months ago (2012-08-08 03:16:27 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=4b7f71e3e390 ***

misc/dashboard/codereview: fixes for non-reviewers.

Also rename the testing CGI argument from "email" to "user".

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6454117
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b