Fix a memory leak in SkBitmapHeap.

Fix a memory leak in SkBitmapHeap.

When I switched fLookupTable to be an array of pointers, I did not
delete those pointers when I was done with them. Do it now.

Also modify SkTDArray::deleteAll to call SkDELETE instead of delete.

Committed: https://code.google.com/p/skia/source/detail?r=5137

[DerekS, 2012-08-16 18:59:23]

https://codereview.appspot.com/6453129/diff/1/src/core/SkBitmapHeap.cpp
File src/core/SkBitmapHeap.cpp (right):

https://codereview.appspot.com/6453129/diff/1/src/core/SkBitmapHeap.cpp#newco...
src/core/SkBitmapHeap.cpp:109: }
can we just use fLookupTable.deleteAll()

[Leon, 2012-08-16 19:05:07]

https://codereview.appspot.com/6453129/diff/1/src/core/SkBitmapHeap.cpp
File src/core/SkBitmapHeap.cpp (right):

https://codereview.appspot.com/6453129/diff/1/src/core/SkBitmapHeap.cpp#newco...
src/core/SkBitmapHeap.cpp:109: }
On 2012/08/16 18:59:23, DerekS wrote:
> can we just use fLookupTable.deleteAll()

Good question. SkTDArray::deleteAll() calls delete, but I think I should be
using SkDELETE because I used SkNEW to create these.

At the moment SkNEW just calls new and SkDELETE just calls delete, but I assume
we have those so clients can change them. I'm guessing that deleteAll should use
SkDELETE as well.

[Leon, 2012-08-16 20:11:21]

https://codereview.appspot.com/6453129/diff/1/src/core/SkBitmapHeap.cpp
File src/core/SkBitmapHeap.cpp (right):

https://codereview.appspot.com/6453129/diff/1/src/core/SkBitmapHeap.cpp#newco...
src/core/SkBitmapHeap.cpp:109: }
On 2012/08/16 19:05:08, scroggo-work wrote:
> On 2012/08/16 18:59:23, DerekS wrote:
> > can we just use fLookupTable.deleteAll()
> 
> Good question. SkTDArray::deleteAll() calls delete, but I think I should be
> using SkDELETE because I used SkNEW to create these.
> 
> At the moment SkNEW just calls new and SkDELETE just calls delete, but I
assume
> we have those so clients can change them. I'm guessing that deleteAll should
use
> SkDELETE as well.

Done.

[DerekS, 2012-08-16 20:28:42]

lgtm