Fix a parenthesis bug.

Fix a parenthesis bug.

SkGPipeCanvas::needOpBytes was being called with the wrong value due to a misplaced
parens in clipRect and clipPath. This can cause a crash if clip is called at just
the right (wrong) time. Instead of writing a boolean to the stream, I have added a
flag, which helps to avoid the parens problem.

Also renamed some flags from _DrawOpsFlag to _DrawOpFlag for consistency.

Lastly, added an assert that the size provided by the SkGPipeController is a multiple
of four.

Committed: https://code.google.com/p/skia/source/detail?r=5134

[junov1, 2012-08-16 13:49:33]

On 2012/08/15 21:35:39, scroggo-work wrote:

The call sequence that would cause a crash, could you put it in a TEST_STEP in
CanvasTest.cpp

Each of these steps gets put through a deferred canvas (and therefore an
SkGPipe.

[Leon, 2012-08-16 15:47:38]

On 2012/08/16 13:49:33, junov1 wrote:
> On 2012/08/15 21:35:39, scroggo-work wrote:
> 
> The call sequence that would cause a crash, could you put it in a TEST_STEP in
> CanvasTest.cpp
> 
> Each of these steps gets put through a deferred canvas (and therefore an
> SkGPipe.

In general, I am pro-testing, but I am not sure how to write a test without
peeking at the internals of SkGPipeCanvas - in particular, MIN_BLOCK_SIZE in
SkGPipeWrite. Ideally, I would do a mock test that changes MIN_BLOCK_SIZE for
the test, but I think we're not set up to do that.

I also do not think this test will help us catch a future regression.

[junov1, 2012-08-16 17:12:03]

Fair enough.

lgtm.