Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1606)

Issue 6453113: Check in r5063 again, along with fix for tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Leon
Modified:
12 years, 3 months ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Check in r5063 again, along with fix for tests. Thank you to Android build, for catching the problem, which would show up elsewhere. Now we access entry->fStorageSlot before deleting entry. (Original message:) Use the SkBitmapHeap to handle SkBitmaps in SkGPipe cross process. Required moving the LRU handles from SkBitmapHeapEntry to LookupEntry. Allows simplification of drawBitmap* calls in SkGPipeCanvas. Committed: https://code.google.com/p/skia/source/detail?r=5081

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -190 lines) Patch
M src/core/SkBitmapHeap.h View 5 chunks +47 lines, -39 lines 0 comments Download
M src/core/SkBitmapHeap.cpp View 12 chunks +92 lines, -55 lines 1 comment Download
M src/pipe/SkGPipeRead.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 18 chunks +78 lines, -94 lines 0 comments Download

Messages

Total messages: 2
Leon
https://codereview.appspot.com/6453113/diff/1/src/core/SkBitmapHeap.cpp File src/core/SkBitmapHeap.cpp (right): https://codereview.appspot.com/6453113/diff/1/src/core/SkBitmapHeap.cpp#newcode271 src/core/SkBitmapHeap.cpp:271: fBytesAllocated -= fStorage[entry->fStorageSlot]->fBytesAllocated; This should be the only difference ...
12 years, 3 months ago (2012-08-13 21:14:16 UTC) #1
DerekS
12 years, 3 months ago (2012-08-14 12:21:01 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b