Issue 6453101: Allow trace categories to be passed into the TraceController

Issue 6453101: Allow trace categories to be passed into the TraceController (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Russ Harmon

Modified:
13 years ago

Reviewers:
nduca

CC:
trace-viewer-review_googlegroups.com, Sonny Rao

Base URL:
https://trace-viewer.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Allow trace categories to be passed into the TraceController BUG=chromium:96123 TEST=manual & run pyauto tracing smoke tests Committed: https://code.google.com/p/trace-viewer/source/detail?r=118

Patch Set 2 : opt_categories #

Total comments: 1

Patch Set 3 : Add documentation for the opt_trace_categories argument. #

Patch Set 4 : Fix documentation #

Total comments: 2

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	src/tracing_controller.js	View	1 2 3	2 chunks	+18 lines, -2 lines	2 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

Russ Harmon

This change depends on the chromium change https://chromiumcodereview.appspot.com/10855062

13 years ago (2012-08-09 00:06:53 UTC) #1

Russ Harmon

https://codereview.appspot.com/6453101/diff/1/src/tracing_controller.js File src/tracing_controller.js (right): https://codereview.appspot.com/6453101/diff/1/src/tracing_controller.js#newcode84 src/tracing_controller.js:84: beginTracing: function(opt_systemTracingEnabled, categories) { opt_categories

13 years ago (2012-08-09 00:49:11 UTC) #2

Russ Harmon

On 2012/08/09 00:06:53, Russ Harmon wrote: > This change depends on the chromium change > ...

13 years ago (2012-08-13 18:47:10 UTC) #3

nduca

https://codereview.appspot.com/6453101/diff/2002/src/tracing_controller.js File src/tracing_controller.js (right): https://codereview.appspot.com/6453101/diff/2002/src/tracing_controller.js#newcode100 src/tracing_controller.js:100: 'beginTracing', document opt_categories and what its format is. Its ...

13 years ago (2012-08-13 19:07:34 UTC) #4

Russ Harmon

On 2012/08/13 19:07:34, nduca wrote: > https://codereview.appspot.com/6453101/diff/2002/src/tracing_controller.js > File src/tracing_controller.js (right): > > https://codereview.appspot.com/6453101/diff/2002/src/tracing_controller.js#newcode100 > ...

13 years ago (2012-08-13 20:18:06 UTC) #5

Russ Harmon

On 2012/08/13 22:37:58, nduca wrote: > No Ok, I've added documentation and renamed the argument ...

13 years ago (2012-08-13 23:26:40 UTC) #7

nduca

https://codereview.appspot.com/6453101/diff/8002/src/tracing_controller.js File src/tracing_controller.js (right): https://codereview.appspot.com/6453101/diff/8002/src/tracing_controller.js#newcode90 src/tracing_controller.js:90: * Example: BeginTracing("test_MyTest*"); BeginTracing->beginTracing https://codereview.appspot.com/6453101/diff/8002/src/tracing_controller.js#newcode114 src/tracing_controller.js:114: ] so I ...

13 years ago (2012-08-13 23:29:49 UTC) #8

Russ Harmon

13 years ago (2012-08-13 23:31:06 UTC) #9

On 2012/08/13 23:29:49, nduca wrote:
> https://codereview.appspot.com/6453101/diff/8002/src/tracing_controller.js
> File src/tracing_controller.js (right):
> 
>
https://codereview.appspot.com/6453101/diff/8002/src/tracing_controller.js#ne...
> src/tracing_controller.js:90: * Example: BeginTracing("test_MyTest*");
> BeginTracing->beginTracing
> 
>
https://codereview.appspot.com/6453101/diff/8002/src/tracing_controller.js#ne...
> src/tracing_controller.js:114: ]
> so I assume you've removed the -test_* flag from the chrome-side fo things?
> 
> LGTM regardless

Yep, pending https://chromiumcodereview.appspot.com/10855062/ getting committed,
https://chromiumcodereview.appspot.com/10855062/patch/1005/5002 removes it.

Expand All Messages | Collapse All Messages