Issue 6453076: Set proper error code when config daemon is not running.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6453076: Set proper error code when config daemon is not running. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Daiki Ueno

Modified:
12 years, 3 months ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Set proper error code when config daemon is not running. BUG=none

Patch Set 2 : add doc for IBUS_ERROR_FAILED #

Total comments: 4

Patch Set 3 : fix typo #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -6 lines)			Patch
	M	src/ibusconfig.c	View	1 2	4 chunks	+17 lines, -6 lines	0 comments	Download
	M	src/ibustypes.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Daiki Ueno

Currently, ibus_config_new() does not set error when configuration daemon is not running. This patch fixes ...

12 years, 3 months ago (2012-08-02 04:55:43 UTC) #1

Peng

lgtm with comments https://codereview.appspot.com/6453076/diff/3001/src/ibusconfig.c File src/ibusconfig.c (right): https://codereview.appspot.com/6453076/diff/3001/src/ibusconfig.c#newcode313 src/ibusconfig.c:313: "Configuration daemon not running."); is not ...

12 years, 3 months ago (2012-08-02 14:52:24 UTC) #2

Daiki Ueno

12 years, 3 months ago (2012-08-03 02:33:56 UTC) #3

https://codereview.appspot.com/6453076/diff/3001/src/ibusconfig.c
File src/ibusconfig.c (right):

https://codereview.appspot.com/6453076/diff/3001/src/ibusconfig.c#newcode313
src/ibusconfig.c:313: "Configuration daemon not running.");
On 2012/08/02 14:52:24, Peng wrote:
> is not running

Done.

https://codereview.appspot.com/6453076/diff/3001/src/ibusconfig.c#newcode376
src/ibusconfig.c:376: "Configuration daemon not running.");
On 2012/08/02 14:52:24, Peng wrote:
> is not running

Done.

Expand All Messages | Collapse All Messages