Move GPU gradients into src/effects/gradients.

Move GPU gradients into src/effects/gradients.
Committed: https://code.google.com/p/skia/source/detail?r=4805

[rileya, 2012-07-27 13:13:36]

I was originally going to move and rename GrGradientEffects to
SkGradientShaderGpu, but everything was small enough that simply moving the
contents into the existing gradient shader files seemed to work better (and
having both the raster and GPU implementations in the same files seems
convenient).

[bsalomon, 2012-07-27 13:33:37]

http://codereview.appspot.com/6453055/diff/1/src/effects/gradients/SkGradient...
File src/effects/gradients/SkGradientShaderPriv.h (right):

http://codereview.appspot.com/6453055/diff/1/src/effects/gradients/SkGradient...
src/effects/gradients/SkGradientShaderPriv.h:23: #include "GrTypes.h"
Do we actually have to include GrTypes.h and GrScalar.h? I think this is an
instance where Skia convention and the IWYU convention clash.

http://codereview.appspot.com/6453055/diff/1/src/effects/gradients/SkGradient...
src/effects/gradients/SkGradientShaderPriv.h:26: #include
"GrProgramStageFactory.h"
Same for this header.

http://codereview.appspot.com/6453055/diff/1/src/effects/gradients/SkTwoPoint...
File src/effects/gradients/SkTwoPointConicalGradient.cpp (right):

http://codereview.appspot.com/6453055/diff/1/src/effects/gradients/SkTwoPoint...
src/effects/gradients/SkTwoPointConicalGradient.cpp:367: GrGLint                
fVSParamLocation;
We don't need these uniform GrGLint locations anymore (in any of these classes).
Either I forget to remove them or they got re-added in code shuffling. In any
event, let's axe them.

[rileya, 2012-07-27 13:50:18]

http://codereview.appspot.com/6453055/diff/1/src/effects/gradients/SkGradient...
File src/effects/gradients/SkGradientShaderPriv.h (right):

http://codereview.appspot.com/6453055/diff/1/src/effects/gradients/SkGradient...
src/effects/gradients/SkGradientShaderPriv.h:23: #include "GrTypes.h"
On 2012/07/27 13:33:37, bsalomon wrote:
> Do we actually have to include GrTypes.h and GrScalar.h? I think this is an
> instance where Skia convention and the IWYU convention clash.

Yep, looks like they weren't necessary, removed.

http://codereview.appspot.com/6453055/diff/1/src/effects/gradients/SkGradient...
src/effects/gradients/SkGradientShaderPriv.h:26: #include
"GrProgramStageFactory.h"
On 2012/07/27 13:33:37, bsalomon wrote:
> Same for this header.

Replaced with forward declare.

http://codereview.appspot.com/6453055/diff/1/src/effects/gradients/SkTwoPoint...
File src/effects/gradients/SkTwoPointConicalGradient.cpp (right):

http://codereview.appspot.com/6453055/diff/1/src/effects/gradients/SkTwoPoint...
src/effects/gradients/SkTwoPointConicalGradient.cpp:367: GrGLint                
fVSParamLocation;
On 2012/07/27 13:33:37, bsalomon wrote:
> We don't need these uniform GrGLint locations anymore (in any of these
classes).
> Either I forget to remove them or they got re-added in code shuffling. In any
> event, let's axe them.
Done.

[bsalomon, 2012-07-27 13:57:59]

LGTM