Issue 6453052: Add virtual destructor to class with virtual functions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6453052: Add virtual destructor to class with virtual functions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by justinlin

Modified:
12 years, 3 months ago

Reviewers:
epoger, TomH, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add virtual destructor to class with virtual functions. BUG= TEST= Committed: https://code.google.com/p/skia/source/detail?r=4810

Patch Set 2 : #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	include/core/SkCanvas.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/core/SkCanvas.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

TomH

Important to do, but the definition of the virtual destructor belongs in a cpp, not ...

12 years, 3 months ago (2012-07-27 14:41:41 UTC) #3

reed1

if we move the destructor first, lgtm https://codereview.appspot.com/6453052/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (left): https://codereview.appspot.com/6453052/diff/1/include/core/SkCanvas.h#oldcode905 include/core/SkCanvas.h:905: virtual void ...

12 years, 3 months ago (2012-07-27 14:41:59 UTC) #4

justinlin

On 2012/07/27 14:41:59, reed1 wrote: > if we move the destructor first, lgtm > > ...

12 years, 3 months ago (2012-07-27 16:44:52 UTC) #5

LGTM; do you need us to land it?

Expand All Messages | Collapse All Messages