Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(381)

Issue 6453047: explicitly track if a path is finite or not (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by reed1
Modified:
11 years, 11 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

explicitly track if a path is finite or not we need this (it appears) so we can definitively reject non-finite paths in canvas, before passing them down into the guts. Committed: https://code.google.com/p/skia/source/detail?r=4784

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -11 lines) Patch
M include/core/SkPath.h View 1 2 chunks +12 lines, -1 line 0 comments Download
M include/core/SkPoint.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
M include/core/SkRect.h View 1 1 chunk +15 lines, -3 lines 0 comments Download
M src/core/SkPath.cpp View 1 7 chunks +14 lines, -6 lines 0 comments Download
M src/core/SkRect.cpp View 1 2 chunks +6 lines, -1 line 0 comments Download
M tests/PathTest.cpp View 1 2 chunks +62 lines, -0 lines 0 comments Download

Messages

Total messages: 2
reed1
will add unittests before final
11 years, 11 months ago (2012-07-25 21:43:43 UTC) #1
bsalomon
11 years, 11 months ago (2012-07-26 12:30:57 UTC) #2
On 2012/07/25 21:43:43, reed1 wrote:
> will add unittests before final

It LGTM (with tests).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b