Merged bench_pictures and render_pictures rendering methods.

Merged bench_pictures and render_pictures rendering methods.

bench_pictures now uses a class based method for choosing the benchmark type as well.

Committed https://code.google.com/p/skia/source/detail?r=4894

[junov1, 2012-07-31 19:19:09]

https://codereview.appspot.com/6452070/diff/2001/gyp/tools.gyp
File gyp/tools.gyp (right):

https://codereview.appspot.com/6452070/diff/2001/gyp/tools.gyp#newcode102
gyp/tools.gyp:102: 'tools.gyp:PictureBenchmark',
picture_benchmark

https://codereview.appspot.com/6452070/diff/2001/tools/PictureBenchmark.h
File tools/PictureBenchmark.h (right):

https://codereview.appspot.com/6452070/diff/2001/tools/PictureBenchmark.h#new...
tools/PictureBenchmark.h:27: int getRepeats(int repeats) {
const

https://codereview.appspot.com/6452070/diff/2001/tools/PictureBenchmark.h#new...
tools/PictureBenchmark.h:39: PipePictureRenderer renderer;
indentation

https://codereview.appspot.com/6452070/diff/2001/tools/PictureBenchmark.h#new...
tools/PictureBenchmark.h:62: int getTileWidth() {
const

https://codereview.appspot.com/6452070/diff/2001/tools/PictureBenchmark.h#new...
tools/PictureBenchmark.h:70: int getTileHeight() {
const

https://codereview.appspot.com/6452070/diff/2001/tools/PictureBenchmark.h#new...
tools/PictureBenchmark.h:78: double getTileWidthPercentage() {
const

https://codereview.appspot.com/6452070/diff/2001/tools/PictureBenchmark.h#new...
tools/PictureBenchmark.h:86: double getTileHeightPercentage() {
const

https://codereview.appspot.com/6452070/diff/2001/tools/PictureRenderer.h
File tools/PictureRenderer.h (right):

https://codereview.appspot.com/6452070/diff/2001/tools/PictureRenderer.h#newc...
tools/PictureRenderer.h:64: double getTileWidthPercentage() {
const

https://codereview.appspot.com/6452070/diff/2001/tools/PictureRenderer.h#newc...
tools/PictureRenderer.h:72: double getTileHeightPercentage() {
const

https://codereview.appspot.com/6452070/diff/2001/tools/PictureRenderer.h#newc...
tools/PictureRenderer.h:76: int numTiles() {
const

https://codereview.appspot.com/6452070/diff/2001/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (right):

https://codereview.appspot.com/6452070/diff/2001/tools/bench_pictures_main.cp...
tools/bench_pictures_main.cpp:196: }
You are leaking benchmark.

https://codereview.appspot.com/6452070/diff/2001/tools/picture_utils.h
File tools/picture_utils.h (right):

https://codereview.appspot.com/6452070/diff/2001/tools/picture_utils.h#newcode28
tools/picture_utils.h:28: // Determines if the string ends with %
Returns true if ...

[junov1, 2012-07-31 19:20:00]

https://codereview.appspot.com/6452070/diff/2001/tools/PictureBenchmark.h
File tools/PictureBenchmark.h (right):

https://codereview.appspot.com/6452070/diff/2001/tools/PictureBenchmark.h#new...
tools/PictureBenchmark.h:27: int getRepeats(int repeats) {
why the repeats parameter?

[keyar, 2012-07-31 20:14:36]

Updated to reflect reviewers wishes.

[junov1, 2012-07-31 20:45:07]

On 2012/07/31 20:14:36, keyar wrote:
> Updated to reflect reviewers wishes.

lgtm