Modified GrGpuGL_unittest to no longer use the old constructors to create gradients, also added Two…

Modified GrGpuGL_unittest to no longer use the old constructors to create gradients, also added TwoPointConical to the tests.
Committed: https://code.google.com/p/skia/source/detail?r=4860

[rileya, 2012-07-31 15:35:54]

The old constructors can now be deleted, and the Gr gradient declarations (minus
the base classes in SkGradientShaderPriv.h) can be moved into source files (I'll
do that in a follow-up CL to avoid cluttering this one up).

[TomH, 2012-07-31 15:39:01]

Big change in unittests. I like. Is there any way to make it less repetitive? I
don't *think* so, in which case LGTM.

http://codereview.appspot.com/6452068/diff/1/src/effects/gradients/SkGradient...
File src/effects/gradients/SkGradientShader.cpp (right):

http://codereview.appspot.com/6452068/diff/1/src/effects/gradients/SkGradient...
src/effects/gradients/SkGradientShader.cpp:645: EXPAND_1_COLOR(colorCount);
Unrelated change?

[bsalomon, 2012-07-31 15:45:04]

LGTM

[rileya, 2012-07-31 15:51:31]

One thing worth noting: this causes the tests to create gradient textures, and
due to the known issue with the cache of gradient bitmaps not being freed, it
results in 32 extra leaked pixel refs when running tests.

http://codereview.appspot.com/6452068/diff/1/src/effects/gradients/SkGradient...
File src/effects/gradients/SkGradientShader.cpp (right):

http://codereview.appspot.com/6452068/diff/1/src/effects/gradients/SkGradient...
src/effects/gradients/SkGradientShader.cpp:645: EXPAND_1_COLOR(colorCount);
On 2012/07/31 15:39:01, TomH wrote:
> Unrelated change?

This turned up after running the tests with the changes. All the other
CreateGradient functions use this to expand single colors into 2, here it was
going through and failing an assert if only one color was passed.

[bsalomon, 2012-07-31 15:57:52]

http://codereview.appspot.com/6452068/diff/1/src/effects/gradients/SkGradient...
File src/effects/gradients/SkGradientShader.cpp (right):

http://codereview.appspot.com/6452068/diff/1/src/effects/gradients/SkGradient...
src/effects/gradients/SkGradientShader.cpp:645: EXPAND_1_COLOR(colorCount);
On 2012/07/31 15:51:31, rileya wrote:
> On 2012/07/31 15:39:01, TomH wrote:
> > Unrelated change?
> 
> This turned up after running the tests with the changes. All the other
> CreateGradient functions use this to expand single colors into 2, here it was
> going through and failing an assert if only one color was passed.

Hooray for unit tests!

[bsalomon, 2012-07-31 15:59:05]

On 2012/07/31 15:51:31, rileya wrote:
> One thing worth noting: this causes the tests to create gradient textures, and
> due to the known issue with the cache of gradient bitmaps not being freed, it
> results in 32 extra leaked pixel refs when running tests.
> 

Not our problem. :)

>
http://codereview.appspot.com/6452068/diff/1/src/effects/gradients/SkGradient...
> File src/effects/gradients/SkGradientShader.cpp (right):
> 
>
http://codereview.appspot.com/6452068/diff/1/src/effects/gradients/SkGradient...
> src/effects/gradients/SkGradientShader.cpp:645: EXPAND_1_COLOR(colorCount);
> On 2012/07/31 15:39:01, TomH wrote:
> > Unrelated change?
> 
> This turned up after running the tests with the changes. All the other
> CreateGradient functions use this to expand single colors into 2, here it was
> going through and failing an assert if only one color was passed.