Issue 6452052: Key Shortcuts for Zooming. Refactored some event propogation.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6452052: Key Shortcuts for Zooming. Refactored some event propogation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by chudy

Modified:
11 years, 11 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Key Shortcuts for Zooming. Refactored some event propogation.

Patch Set 2 : Addressed patch 1 comments #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -11 lines)			Patch
M	debugger/QT/SkCanvasWidget.h	View		2 chunks	+9 lines, -2 lines	0 comments	Download
M	debugger/QT/SkCanvasWidget.cpp	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View		4 chunks	+17 lines, -0 lines	0 comments	Download
M	debugger/QT/moc_SkCanvasWidget.cpp	View		5 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DerekS

small nit but lgtm https://codereview.appspot.com/6452052/diff/1/debugger/QT/SkCanvasWidget.cpp File debugger/QT/SkCanvasWidget.cpp (right): https://codereview.appspot.com/6452052/diff/1/debugger/QT/SkCanvasWidget.cpp#newcode116 debugger/QT/SkCanvasWidget.cpp:116: fScaleFactor += 2 * zoomIncrement; ...

11 years, 11 months ago (2012-07-26 20:19:42 UTC) #2

chudy

11 years, 11 months ago (2012-07-26 20:27:00 UTC) #3

Fixed and submitting. Thanks for the review!

https://codereview.appspot.com/6452052/diff/1/debugger/QT/SkCanvasWidget.cpp
File debugger/QT/SkCanvasWidget.cpp (right):

https://codereview.appspot.com/6452052/diff/1/debugger/QT/SkCanvasWidget.cpp#...
debugger/QT/SkCanvasWidget.cpp:116: fScaleFactor += 2 * zoomIncrement;
On 2012/07/26 20:19:42, DerekS wrote:
> just make this = as += doesn't really make sense here.

Done.

Expand All Messages | Collapse All Messages