Issue 6452050: Reapply "Remove Bitmaps Raw Pixel Support."

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6452050: Reapply "Remove Bitmaps Raw Pixel Support." (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by DerekS

Modified:
11 years, 11 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Reapply "Remove Bitmaps Raw Pixel Support." This CL reapplies r4722. Now that we have addressed the issues in Chrome tests that were causing asserts to be fired. Committed: https://code.google.com/p/skia/source/detail?r=4804

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -77 lines)			Patch
M	include/core/SkBitmap.h	View	3 chunks	+6 lines, -10 lines	0 comments	Download
M	include/core/SkMallocPixelRef.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/core/SkBitmap.cpp	View	9 chunks	+8 lines, -63 lines	0 comments	Download
M	src/core/SkMallocPixelRef.cpp	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/core/SkPixelRef.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

On 2012/07/26 20:47:46, DerekS wrote: Are the WK changes that are required also rolled into ...

11 years, 11 months ago (2012-07-26 21:00:49 UTC) #2

DerekS

On 2012/07/26 21:00:49, bsalomon wrote: > On 2012/07/26 20:47:46, DerekS wrote: > > Are the ...

11 years, 11 months ago (2012-07-27 13:15:44 UTC) #3

bsalomon

11 years, 11 months ago (2012-07-27 13:33:52 UTC) #5

On 2012/07/27 13:33:40, reed1 wrote:
> go go gadget!

w00t LGTM

Expand All Messages | Collapse All Messages