Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 6450109: code review 6450109: exp/html: ignore self-closing flag except in SVG and MathML (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by andybalholm
Modified:
12 years, 7 months ago
Reviewers:
CC:
nigeltao, golang-dev
Visibility:
Public.

Description

exp/html: ignore self-closing flag except in SVG and MathML In HTML content, having a self-closing tag is a parse error unless the tag would be self-closing anyway (like <img>). The only place a self-closing tag actually makes a difference is in XML-based foreign content. Pass 1 additional test.

Patch Set 1 #

Patch Set 2 : diff -r 0934e2afdec9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0934e2afdec9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/pkg/exp/html/parse.go View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/pkg/exp/html/testlogs/webkit01.dat.log View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
andybalholm
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 7 months ago (2012-08-09 15:32:40 UTC) #1
nigeltao
LGTM. I find this surprising, but I shouldn't be: it's HTML5.
12 years, 7 months ago (2012-08-09 23:33:57 UTC) #2
nigeltao
12 years, 7 months ago (2012-08-09 23:34:23 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=823f9cd8acba ***

exp/html: ignore self-closing flag except in SVG and MathML

In HTML content, having a self-closing tag is a parse error unless
the tag would be self-closing anyway (like <img>). The only place a
self-closing tag actually makes a difference is in XML-based foreign
content.

Pass 1 additional test.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/6450109

Committer: Nigel Tao <nigeltao@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b