Issue 6450099: Even when the pts are restricted to 32K values, we can still overflow computing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6450099: Even when the pts are restricted to 32K values, we can still overflow computing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by reed1

Modified:
12 years, 3 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Even when the pts are restricted to 32K values, we can still overflow computing a fixed-point coefficient for quadratics. To avoid this, we bias these coefficients, storing 1/2 of their actual value, and then apply the 2x unbias in updateQuadratic(). Fixes http://code.google.com/p/chromium/issues/detail?id=140803 Committed: https://code.google.com/p/skia/source/detail?r=4960

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -5 lines)			Patch
	M	src/core/SkEdge.cpp	View	1	2 chunks	+30 lines, -5 lines	0 comments	Download
	M	tests/DrawPathTest.cpp	View	1 2	2 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

unit test that failed on the old code? https://codereview.appspot.com/6450099/diff/2001/src/core/SkEdge.cpp File src/core/SkEdge.cpp (right): https://codereview.appspot.com/6450099/diff/2001/src/core/SkEdge.cpp#newcode249 src/core/SkEdge.cpp:249: */ ...

12 years, 3 months ago (2012-08-06 18:46:17 UTC) #2

bsalomon

12 years, 3 months ago (2012-08-06 19:01:16 UTC) #4

On 2012/08/06 18:55:49, reed1 wrote:
> unittest added

LGTM

Expand All Messages | Collapse All Messages