Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 6450099: Even when the pts are restricted to 32K values, we can still overflow computing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by reed1
Modified:
2 years, 11 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Even when the pts are restricted to 32K values, we can still overflow computing a fixed-point coefficient for quadratics. To avoid this, we bias these coefficients, storing 1/2 of their actual value, and then apply the 2x unbias in updateQuadratic(). Fixes http://code.google.com/p/chromium/issues/detail?id=140803 Committed: https://code.google.com/p/skia/source/detail?r=4960

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -5 lines) Patch
M src/core/SkEdge.cpp View 1 2 chunks +30 lines, -5 lines 0 comments Download
M tests/DrawPathTest.cpp View 1 2 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4
reed1
2 years, 11 months ago (2012-08-06 18:33:44 UTC) #1
bsalomon
unit test that failed on the old code? https://codereview.appspot.com/6450099/diff/2001/src/core/SkEdge.cpp File src/core/SkEdge.cpp (right): https://codereview.appspot.com/6450099/diff/2001/src/core/SkEdge.cpp#newcode249 src/core/SkEdge.cpp:249: */ ...
2 years, 11 months ago (2012-08-06 18:46:17 UTC) #2
reed1
unittest added
2 years, 11 months ago (2012-08-06 18:55:49 UTC) #3
bsalomon
2 years, 11 months ago (2012-08-06 19:01:16 UTC) #4
On 2012/08/06 18:55:49, reed1 wrote:
> unittest added

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5