Issue 6450083: Correct crash in texture key generation by early-outing if no texture is present.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6450083: Correct crash in texture key generation by early-outing if no texture is present. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by twiz1

Modified:
12 years, 3 months ago

Reviewers:
reed1, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Early out the texture key generation if there is no texture passed to the GrGLShaderBuilder::keyForTextureAccess. Under normal circumstances, there will always be a passed texture. However, when running in the unit tests, CustomStages are constructed without a texture input. Committed: https://code.google.com/p/skia/source/detail?r=4924

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/gpu/gl/GrGLShaderBuilder.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

twiz1

PTAL. This should resolve the failing GLPrograms test observed on mac.

12 years, 3 months ago (2012-08-02 17:27:50 UTC) #1

twiz1

12 years, 3 months ago (2012-08-02 17:33:01 UTC) #3

On 2012/08/02 17:28:24, TomH wrote:
> LGTM. Go!

Committed: https://code.google.com/p/skia/source/detail?r=4924

Expand All Messages | Collapse All Messages