Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(692)

Issue 6450053: Share code in various SkGPipeCanvas::drawBitmap_ calls. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by Leon
Modified:
12 years, 4 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Share code in various SkGPipeCanvas::drawBitmap_ calls. Also implement SkGPipeCanvas::drawBitmapMatrix, and create a GM to make sure it works properly. Use a flag instead of writing a bool for determining whether drawBitmap_ has a paint and whether drawBitmapRect has a source rectangle. BUG= TEST=drawbitmapmatrix GM Committed: https://code.google.com/p/skia/source/detail?r=4828

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -111 lines) Patch
A gm/bitmapmatrix.cpp View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 1 4 chunks +12 lines, -6 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 4 chunks +88 lines, -105 lines 0 comments Download

Messages

Total messages: 5
Leon
12 years, 4 months ago (2012-07-26 19:54:17 UTC) #1
reed1
can we make the gm picture prettier? https://codereview.appspot.com/6450053/diff/1/src/pipe/SkGPipePriv.h File src/pipe/SkGPipePriv.h (right): https://codereview.appspot.com/6450053/diff/1/src/pipe/SkGPipePriv.h#newcode142 src/pipe/SkGPipePriv.h:142: // which ...
12 years, 4 months ago (2012-07-26 21:20:03 UTC) #2
Leon
https://codereview.appspot.com/6450053/diff/1/src/pipe/SkGPipePriv.h File src/pipe/SkGPipePriv.h (right): https://codereview.appspot.com/6450053/diff/1/src/pipe/SkGPipePriv.h#newcode142 src/pipe/SkGPipePriv.h:142: // which is used for all drawBitmap calls, so ...
12 years, 4 months ago (2012-07-26 22:06:15 UTC) #3
Leon
New patch uploaded addressing comments.
12 years, 4 months ago (2012-07-30 13:24:37 UTC) #4
reed1
12 years, 4 months ago (2012-07-30 14:15:54 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b