Issue 6449127: code review 6449127: cmd/5l: embed $GOARM value into binary as runtime.goarm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6449127: code review 6449127: cmd/5l: embed $GOARM value into binary as runtime.goarm (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by minux1

Modified:
12 years, 7 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net, rsc

Visibility:
Public.

Description

cmd/5l: embed $GOARM value into binary as runtime.goarm

Patch Set 1 #

Patch Set 2 : diff -r 62f087306b18 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 62f087306b18 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 62f087306b18 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 62f087306b18 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 272e1dd72156 https://code.google.com/p/go/ #

Patch Set 7 : diff -r 2323dc1ecb83 https://code.google.com/p/go/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	src/cmd/5l/l.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/cmd/5l/obj.c	View	1 2 3	3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 8 months ago (2012-08-10 12:20:13 UTC) #1

dave_cheney.net

LGTM combined with http://codereview.appspot.com/6442109/

12 years, 8 months ago (2012-08-21 01:12:16 UTC) #2

minux1

12 years, 7 months ago (2012-09-02 19:52:11 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=c2fb0e36f5e8 ***

cmd/5l: embed $GOARM value into binary as runtime.goarm

R=golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6449127

Expand All Messages | Collapse All Messages