Round swap chain surfaces to 64 pixels in width.

Round swap chain surfaces to 64 pixels in width.
Committed: https://code.google.com/p/angleproject/source/detail?r=1245

[apatrick1, 2012-08-09 20:46:03]

Hi Daniel,

I would like to see if this fixes this bug: http://crbug/140239 . If it does
I'll cry and if it doesn't I'll back it out.

PTAL.

Al

https://codereview.appspot.com/6449123/diff/1/src/libEGL/Surface.cpp
File src/libEGL/Surface.cpp (right):

https://codereview.appspot.com/6449123/diff/1/src/libEGL/Surface.cpp#newcode295
src/libEGL/Surface.cpp:295: if (mConfig->mDepthStencilFormat != D3DFMT_UNKNOWN)
This is less of a change than it looks. I swapped the order that the depth
stencil buffer and swap chain are created so that the width of the depth stencil
buffer is not rounded. It should be the same width as the render target texture,
which is also unchanged.

https://codereview.appspot.com/6449123/diff/1/src/libEGL/Surface.cpp#newcode325
src/libEGL/Surface.cpp:325: // http://crbug/140239
This block here is the only addition. It rounds the width after it has been used
unrounded by everything else.

[nicolas, 2012-08-09 22:04:33]

The concept of rounding it up to a multiple of 64 pixels looks fine. Got a
couple comments though.

https://codereview.appspot.com/6449123/diff/1/src/libEGL/Surface.cpp
File src/libEGL/Surface.cpp (right):

https://codereview.appspot.com/6449123/diff/1/src/libEGL/Surface.cpp#newcode297
src/libEGL/Surface.cpp:297: result =
device->CreateDepthStencilSurface(presentParameters.BackBufferWidth,
presentParameters.BackBufferHeight,
Perhaps this shouldn't be using presentParameters in the first place. That way
the order of construction can be kept the same too.

https://codereview.appspot.com/6449123/diff/1/src/libEGL/Surface.cpp#newcode325
src/libEGL/Surface.cpp:325: // http://crbug/140239
I can't seem to open such a link.

[apatrick1, 2012-08-09 22:41:29]

Yeah it looks better that way I think. Fixed link too.

[nicolas, 2012-08-10 15:14:05]

Looks good. Thanks.

[dgkoch, 2012-08-13 18:59:20]

I definitely approve of the refactoring here :-)

https://codereview.appspot.com/6449123/diff/3001/src/libEGL/Surface.cpp
File src/libEGL/Surface.cpp (right):

https://codereview.appspot.com/6449123/diff/3001/src/libEGL/Surface.cpp#newco...
src/libEGL/Surface.cpp:346: mHeight = backbufferHeight;
with this change you should now be able to easily add in your check on the
present parameters to upsize 0x0 sizes to 1x1 without mucking up the surface
dimensions.