Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(219)

Issue 6449123: Round swap chain surfaces to 64 pixels in width. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by apatrick1
Modified:
13 years, 8 months ago
Reviewers:
dgkoch, nicolas
CC:
angleproject-review_googlegroups.com, John Bauman
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Round swap chain surfaces to 64 pixels in width. Committed: https://code.google.com/p/angleproject/source/detail?r=1245

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M src/libEGL/Surface.cpp View 1 6 chunks +30 lines, -31 lines 1 comment Download

Messages

Total messages: 5
apatrick1
Hi Daniel, I would like to see if this fixes this bug: http://crbug/140239 . If ...
13 years, 8 months ago (2012-08-09 20:46:03 UTC) #1
nicolas
The concept of rounding it up to a multiple of 64 pixels looks fine. Got ...
13 years, 8 months ago (2012-08-09 22:04:33 UTC) #2
apatrick1
Yeah it looks better that way I think. Fixed link too.
13 years, 8 months ago (2012-08-09 22:41:29 UTC) #3
nicolas
Looks good. Thanks.
13 years, 8 months ago (2012-08-10 15:14:05 UTC) #4
dgkoch
13 years, 8 months ago (2012-08-13 18:59:20 UTC) #5
I definitely approve of the refactoring here :-)

https://codereview.appspot.com/6449123/diff/3001/src/libEGL/Surface.cpp
File src/libEGL/Surface.cpp (right):

https://codereview.appspot.com/6449123/diff/3001/src/libEGL/Surface.cpp#newco...
src/libEGL/Surface.cpp:346: mHeight = backbufferHeight;
with this change you should now be able to easily add in your check on the
present parameters to upsize 0x0 sizes to 1x1 without mucking up the surface
dimensions.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b