Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(354)

Issue 6449110: arm: dynamic NEON support for SkBlitRow_opts_arm.cpp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by digit1
Modified:
12 years, 4 months ago
Reviewers:
DerekS, caryclark1, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

arm: dynamic NEON support for SkBlitRow_opts_arm.cpp This patch moves all NEON-specific code from the source src/opts/SkBlitRow_opts_arm.cpp into a new file that is built as part of the 'opts_arm_neon' static library. Committed: https://code.google.com/p/skia/source/detail?r=5016

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -1485 lines) Patch
M gyp/opts.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A src/opts/SkBlitRow_opts_arm.h View 1 chunk +41 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm.cpp View 5 chunks +30 lines, -1130 lines 0 comments Download
A + src/opts/SkBlitRow_opts_arm_neon.cpp View 1 13 chunks +42 lines, -355 lines 0 comments Download

Messages

Total messages: 6
digit1
In case you didn't get an email, this is the last-but-one patch for complete dynamic ...
12 years, 4 months ago (2012-08-08 15:24:24 UTC) #1
DerekS
http://codereview.appspot.com/6449110/diff/1/src/opts/SkBlitRow_opts_arm_neon.cpp File src/opts/SkBlitRow_opts_arm_neon.cpp (right): http://codereview.appspot.com/6449110/diff/1/src/opts/SkBlitRow_opts_arm_neon.cpp#newcode1079 src/opts/SkBlitRow_opts_arm_neon.cpp:1079: NULL, // S32_D565_Blend we seem to loose this logic ...
12 years, 4 months ago (2012-08-08 17:42:35 UTC) #2
digit1
http://codereview.appspot.com/6449110/diff/1/src/opts/SkBlitRow_opts_arm_neon.cpp File src/opts/SkBlitRow_opts_arm_neon.cpp (right): http://codereview.appspot.com/6449110/diff/1/src/opts/SkBlitRow_opts_arm_neon.cpp#newcode1079 src/opts/SkBlitRow_opts_arm_neon.cpp:1079: NULL, // S32_D565_Blend Very nice catch. I'll fix this. ...
12 years, 4 months ago (2012-08-08 19:09:32 UTC) #3
digit1
Should be fixed in patch set 2.
12 years, 4 months ago (2012-08-08 19:09:46 UTC) #4
caryclark1
I don't know this code at all so I'm going to defer to Derek this ...
12 years, 4 months ago (2012-08-08 19:14:27 UTC) #5
DerekS
12 years, 4 months ago (2012-08-08 20:42:02 UTC) #6
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b