Issue 6449103: conf: cleanup GError usage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6449103: conf: cleanup GError usage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Daiki Ueno

Modified:
12 years, 3 months ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

conf: cleanup GError usage - there are missing g_error_free - some code assume error != NULL when setting *error - src/tests/ibus-config.c has unconditional "unset" but it checks the return value BUG=none

Patch Set 1 #

Patch Set 2 : check if config value really exists #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -22 lines)			Patch
M	conf/dconf/config.c	View		3 chunks	+15 lines, -6 lines	0 comments	Download
M	conf/gconf/config.c	View		3 chunks	+9 lines, -10 lines	0 comments	Download
M	conf/gconf/main.c	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	conf/memconf/config.c	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/tests/ibus-config.c	View	1	1 chunk	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Daiki Ueno

- there are missing g_error_free - some code assume error != NULL when setting *error ...

12 years, 3 months ago (2012-08-07 07:22:53 UTC) #1

Peng

12 years, 3 months ago (2012-08-07 14:44:49 UTC) #2

LGTM. Could you please copy below info to CL description? Thanks.

On 2012/08/07 07:22:53, Daiki Ueno wrote:
> - there are missing g_error_free
> - some code assume error != NULL when setting *error
> - src/tests/ibus-config.c has unconditional "unset" but it checks the return
> value

Expand All Messages | Collapse All Messages