Remove old constructors from GrGradientEffect subclasses, and moved their declarations into source …

Remove old constructors from GrGradientEffect subclasses, and moved their declarations into source files.
Committed: https://code.google.com/p/skia/source/detail?r=4870

[TomH, 2012-07-31 17:35:22]

LGTM.

We get the source code a tiny bit shorter by inlining the member functions, now
that the class declaration is in the .cpp file; in a couple of cases (e.g.
destructor is { }) I'd like to see that, but I'm not sure it's worth doing in
general. (It's a question I went back and forth on as I was writing the GrGL
classes in the first place.)

[bsalomon, 2012-07-31 17:40:09]

http://codereview.appspot.com/6449067/diff/1/src/effects/gradients/SkLinearGr...
File src/effects/gradients/SkLinearGradient.cpp (right):

http://codereview.appspot.com/6449067/diff/1/src/effects/gradients/SkLinearGr...
src/effects/gradients/SkLinearGradient.cpp:65: class GrGLLinearGradient;
Since I'm going to have to put #if/#endif around all the GPU code it'd be nice
if as much of it as possbile could be grouped together. This might mean
asNewCustomStage() is the last thing in the file, after the Gr classes.

[bsalomon, 2012-07-31 17:41:19]

On 2012/07/31 17:35:22, TomH wrote:
> LGTM.
> 
> We get the source code a tiny bit shorter by inlining the member functions,
now
> that the class declaration is in the .cpp file; in a couple of cases (e.g.
> destructor is { }) I'd like to see that, but I'm not sure it's worth doing in
> general. (It's a question I went back and forth on as I was writing the GrGL
> classes in the first place.)

I almost made the same suggestion. For the trivial functions inlining would
probably improve  readability.

[rileya, 2012-07-31 20:22:14]

I moved all the GrGradientEffect subclass declarations to the end of the files
with their GrGL counterparts, and since none of their functions were more than a
few lines, inlined all of them into those class declarations.

As suggested, this required moving asNewCustomStage to the bottom of each file,
as well as a few other small moves due to interdependence between the Gr and
GrGL classes.

[bsalomon, 2012-07-31 20:30:43]

On 2012/07/31 20:22:14, rileya wrote:
> I moved all the GrGradientEffect subclass declarations to the end of the files
> with their GrGL counterparts, and since none of their functions were more than
a
> few lines, inlined all of them into those class declarations.
> 
> As suggested, this required moving asNewCustomStage to the bottom of each
file,
> as well as a few other small moves due to interdependence between the Gr and
> GrGL classes.

LGTM