Renamed and made public SkGradientShaderBases's 'commonAsAGradient' to 'getGradientTableBitmap', an…

Renamed and made public SkGradientShaderBases's 'commonAsAGradient' to 'getGradientTableBitmap', and use that instead of asABitmap in gradient custom stage setup.

Also tidied up Gr gradient implementation constructors, to take the appropriate SkGradientShaderBase subclass, and where necessary (namely 2pt radial/conical) made them obtain extra parameters from that object, rather than passing them in in addition to it.
Committed: https://code.google.com/p/skia/source/detail?r=4808

[rileya, 2012-07-27 15:14:51]

http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkGradi...
File src/effects/gradients/SkGradientShaderPriv.h (right):

http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkGradi...
src/effects/gradients/SkGradientShaderPriv.h:225: GrGradientEffect(GrTexture*
texture);
I wanted to completely remove the gradient effect constructors that take a
GrTexture, but GrGpuGL_unittests.cpp still uses them, and I didn't see an easy
way of subbing in the new ones there.

[bsalomon, 2012-07-27 15:21:08]

We need to figure out a better way to test the shader generator... perhaps some
method for GrCustomStages to auto-register themselves to with the tester and
able to configure themselves randomly.

http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkTwoPo...
File src/effects/gradients/SkTwoPointConicalGradient.h (right):

http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkTwoPo...
src/effects/gradients/SkTwoPointConicalGradient.h:67: GrScalar getCenterX1()
const { return SkPoint::Distance(fCenter1, fCenter2); }
Let's call them SkScalar since they're in an Sk class.

[rileya, 2012-07-27 15:32:44]

On 2012/07/27 15:21:08, bsalomon wrote:
> We need to figure out a better way to test the shader generator... perhaps
some
> method for GrCustomStages to auto-register themselves to with the tester and
> able to configure themselves randomly.

Is there anything I can do towards that end with this CL?

http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkTwoPo...
File src/effects/gradients/SkTwoPointConicalGradient.h (right):

http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkTwoPo...
src/effects/gradients/SkTwoPointConicalGradient.h:67: GrScalar getCenterX1()
const { return SkPoint::Distance(fCenter1, fCenter2); }
On 2012/07/27 15:21:08, bsalomon wrote:
> Let's call them SkScalar since they're in an Sk class.

Fixed.

[bsalomon, 2012-07-27 15:34:34]

LGTM

On 2012/07/27 15:32:44, rileya wrote:
> On 2012/07/27 15:21:08, bsalomon wrote:
> > We need to figure out a better way to test the shader generator... perhaps
> some
> > method for GrCustomStages to auto-register themselves to with the tester and
> > able to configure themselves randomly.
> 
> Is there anything I can do towards that end with this CL?

I think it's a separate task. Can you stick a comment on the texture cons that
it is there for the unit test?

> 
>
http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkTwoPo...
> File src/effects/gradients/SkTwoPointConicalGradient.h (right):
> 
>
http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkTwoPo...
> src/effects/gradients/SkTwoPointConicalGradient.h:67: GrScalar getCenterX1()
> const { return SkPoint::Distance(fCenter1, fCenter2); }
> On 2012/07/27 15:21:08, bsalomon wrote:
> > Let's call them SkScalar since they're in an Sk class.
> 
> Fixed.

[rileya, 2012-07-27 15:44:50]

On 2012/07/27 15:34:34, bsalomon wrote:
> LGTM
> 
> On 2012/07/27 15:32:44, rileya wrote:
> > On 2012/07/27 15:21:08, bsalomon wrote:
> > > We need to figure out a better way to test the shader generator... perhaps
> > some
> > > method for GrCustomStages to auto-register themselves to with the tester
and
> > > able to configure themselves randomly.
> > 
> > Is there anything I can do towards that end with this CL?
> 
> I think it's a separate task. Can you stick a comment on the texture cons that
> it is there for the unit test?
> 
> > 
> >
>
http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkTwoPo...
> > File src/effects/gradients/SkTwoPointConicalGradient.h (right):
> > 
> >
>
http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkTwoPo...
> > src/effects/gradients/SkTwoPointConicalGradient.h:67: GrScalar getCenterX1()
> > const { return SkPoint::Distance(fCenter1, fCenter2); }
> > On 2012/07/27 15:21:08, bsalomon wrote:
> > > Let's call them SkScalar since they're in an Sk class.
> > 
> > Fixed.

Alright, added the comment.

[bsalomon, 2012-07-27 15:48:30]

On 2012/07/27 15:44:50, rileya wrote:
> On 2012/07/27 15:34:34, bsalomon wrote:
> > LGTM
> > 
> > On 2012/07/27 15:32:44, rileya wrote:
> > > On 2012/07/27 15:21:08, bsalomon wrote:
> > > > We need to figure out a better way to test the shader generator...
perhaps
> > > some
> > > > method for GrCustomStages to auto-register themselves to with the tester
> and
> > > > able to configure themselves randomly.
> > > 
> > > Is there anything I can do towards that end with this CL?
> > 
> > I think it's a separate task. Can you stick a comment on the texture cons
that
> > it is there for the unit test?
> > 
> > > 
> > >
> >
>
http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkTwoPo...
> > > File src/effects/gradients/SkTwoPointConicalGradient.h (right):
> > > 
> > >
> >
>
http://codereview.appspot.com/6449057/diff/2001/src/effects/gradients/SkTwoPo...
> > > src/effects/gradients/SkTwoPointConicalGradient.h:67: GrScalar
getCenterX1()
> > > const { return SkPoint::Distance(fCenter1, fCenter2); }
> > > On 2012/07/27 15:21:08, bsalomon wrote:
> > > > Let's call them SkScalar since they're in an Sk class.
> > > 
> > > Fixed.
> 
> Alright, added the comment.

LGTM