Issue 6449049: Revert "Remove Bitmaps Raw Pixel Support."

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6449049: Revert "Remove Bitmaps Raw Pixel Support." (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by DerekS

Modified:
11 years, 11 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Revert "Remove Bitmaps Raw Pixel Support." BUG= TEST= Committed: https://code.google.com/p/skia/source/detail?r=4780

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -23 lines)			Patch
M	include/core/SkBitmap.h	View	3 chunks	+10 lines, -6 lines	0 comments	Download
M	include/core/SkMallocPixelRef.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/core/SkBitmap.cpp	View	9 chunks	+63 lines, -8 lines	0 comments	Download
M	src/core/SkMallocPixelRef.cpp	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	src/core/SkPixelRef.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

lgtm might be helpful to include a brief reason. e.g. revert rev. #### as we ...

11 years, 11 months ago (2012-07-26 14:40:26 UTC) #2

bsalomon

11 years, 11 months ago (2012-07-26 14:44:45 UTC) #3

LGTM


On Thu, Jul 26, 2012 at 10:40 AM, <reed@google.com> wrote:

> lgtm
>
> might be helpful to include a brief reason. e.g.
>
> revert rev. #### as we hit asserts in chrome tests. hope to fix those
> and re-submit this change.
>
>
http://codereview.appspot.com/**6449049/<http://codereview.appspot.com/6449049/>
>

Expand All Messages | Collapse All Messages