Issue 6448174: Images are written by PictureRenderer and not render_pictures_main.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6448174: Images are written by PictureRenderer and not render_pictures_main. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by keyar

Modified:
12 years, 3 months ago

Reviewers:
junov1

CC:
skia-review_googlegroups.com, benchen

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Images are written by PictureRenderer and not render_pictures_main. Committed https://code.google.com/p/skia/source/detail?r=5216

Patch Set 2 : Removed getCanvas #

Total comments: 1

Patch Set 4 : #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -37 lines)			Patch
M	gyp/tools.gyp	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	tools/PictureRenderer.h	View	1 2 3	3 chunks	+3 lines, -4 lines	0 comments	Download
M	tools/PictureRenderer.cpp	View	1 2 3	2 chunks	+18 lines, -0 lines	0 comments	Download
M	tools/picture_utils.h	View	1 2 3	2 chunks	+9 lines, -1 line	0 comments	Download
M	tools/picture_utils.cpp	View	1 2 3	1 chunk	+15 lines, -0 lines	0 comments	Download
M	tools/render_pictures_main.cpp	View		3 chunks	+3 lines, -29 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

junov1

https://codereview.appspot.com/6448174/diff/4001/tools/picture_utils.cpp File tools/picture_utils.cpp (right): https://codereview.appspot.com/6448174/diff/4001/tools/picture_utils.cpp#newcode20 tools/picture_utils.cpp:20: *bitmap.getAddr32(x, y) |= (SK_A32_MASK << SK_A32_SHIFT); Is it safe ...

12 years, 3 months ago (2012-08-20 20:32:04 UTC) #3

junov1

On 2012/08/20 20:55:13, keyar wrote: > Made fixes as requested by reviewers. lgtm

12 years, 3 months ago (2012-08-21 18:42:52 UTC) #5

junov1

12 years, 3 months ago (2012-08-21 19:00:36 UTC) #7

On 2012/08/21 18:57:19, keyar wrote:
> Fixed no-GPU build.

lgtm

Expand All Messages | Collapse All Messages