code review 6448166: go.crypto/ssh: fix misplaced defer

go.crypto/ssh: fix misplaced defer

Fixes issue 3972.

[dave_cheney.net, 2012-08-18 02:01:51]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.crypto

[agl2, 2012-08-18 02:03:43]

LGTM
On Aug 17, 2012 7:01 PM, <dave@cheney.net> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.**crypto<https://code.google.com/p/go.crypto>
>
>
> Description:
> go.crypto/ssh: fix misplaced defer
>
> Fixes issue 3972.
>
> Please review this at
http://codereview.appspot.com/**6448166/<http://codereview.appspot.com/6448166/>
>
> Affected files:
>   M ssh/client_auth_test.go
>
>
> Index: ssh/client_auth_test.go
> ==============================**==============================**=======
> --- a/ssh/client_auth_test.go
> +++ b/ssh/client_auth_test.go
> @@ -160,7 +160,6 @@
>         go func() {
>                 defer l.Close()
>                 c, err := l.Accept()
> -               defer c.Close()
>                 if err != nil {
>                         t.Errorf("Unable to accept incoming connection:
> %v", err)
>                         return
> @@ -171,6 +170,7 @@
>                         t.Logf("Handshaking error: %v", err)
>                         return
>                 }
> +               defer c.Close()
>         }()
>         return l.Addr().String()
>  }
>
>
>

[r, 2012-08-18 04:54:26]

LGTM

[dave_cheney.net, 2012-08-18 05:41:50]

*** Submitted as
http://code.google.com/p/go/source/detail?r=7997ecacd006&repo=crypto ***

go.crypto/ssh: fix misplaced defer

Fixes issue 3972.

R=golang-dev, agl, r
CC=golang-dev
http://codereview.appspot.com/6448166