Issue 6448092: Refines API and documents.

Issue 6448092: Refines API and documents. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by hsumita1

Modified:
11 years, 9 months ago

Reviewers:
shawn.p.huang, Peng Huang, penghuang

Base URL:
git@github.com:pyzy/pyzy.git@master

Visibility:
Public.

More Reviews

Description

Refines API and documents. BUG=Can't get candidates on InputContext::Observer::candidatesChanged().

Patch Set 1 #

Patch Set 2 : Removes unnecessary inclusion from sample code. #

Patch Set 3 : Update version number. #

Total comments: 1

Patch Set 4 : fix style. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -9 lines)			Patch
M	configure.ac	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	docs/Doxyfile.in	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	docs/mainpage.txt	View	1 2 3	1 chunk	+80 lines, -0 lines	0 comments	Download
M	src/InputContext.h	View		7 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

hsumita1

On 2012/08/01 08:01:19, hsumita1 wrote: Hi Peng Could you support this patch on ibus-pinyin? I ...

11 years, 9 months ago (2012-08-01 08:30:27 UTC) #2

On 2012/08/01 08:01:19, hsumita1 wrote:

Hi Peng
Could you support this patch on ibus-pinyin?
I don't know how to send a patch to pyzy branch of ibus-pinyin using git-cl.

----- patch for ibus-pinyin -----

commit 489724cfe920d4eb5d2b96a0698b1b3a10973177
Author: Hiroshi Sumita <hsumita@chromium.org>
Date:   Wed Aug 1 17:19:57 2012 +0900

    Support pyzy 0.0.9

diff --git a/src/PYPinyinObserver.cc b/src/PYPinyinObserver.cc
index 89add3f..2088a0e 100644
--- a/src/PYPinyinObserver.cc
+++ b/src/PYPinyinObserver.cc
@@ -32,33 +32,33 @@ PinyinObserver::PinyinObserver (PhoneticEditor &editor)
 }
 
 void
-PinyinObserver::commitText (const PyZy::InputContext * context,
+PinyinObserver::commitText (PyZy::InputContext * context,
                             const std::string &commit_text)
 {
     m_editor.commitCallback (String(commit_text));
 }
 
-void PinyinObserver::inputTextChanged (const PyZy::InputContext * context)
+void PinyinObserver::inputTextChanged (PyZy::InputContext * context)
 {
     m_editor.updateInputText ();
 }
 
-void PinyinObserver::cursorChanged (const PyZy::InputContext * context)
+void PinyinObserver::cursorChanged (PyZy::InputContext * context)
 {
     m_editor.updateCursor ();
 }
 
-void PinyinObserver::preeditTextChanged (const PyZy::InputContext * context)
+void PinyinObserver::preeditTextChanged (PyZy::InputContext * context)
 {
     m_editor.updatePreeditText ();
 }
 
-void PinyinObserver::auxiliaryTextChanged (const PyZy::InputContext * context)
+void PinyinObserver::auxiliaryTextChanged (PyZy::InputContext * context)
 {
     m_editor.updateAuxiliaryText ();
 }
 
-void PinyinObserver::candidatesChanged (const PyZy::InputContext * context)
+void PinyinObserver::candidatesChanged (PyZy::InputContext * context)
 {
     m_editor.updateLookupTable ();
 }
diff --git a/src/PYPinyinObserver.h b/src/PYPinyinObserver.h
index 80c054d..00116b6 100644
--- a/src/PYPinyinObserver.h
+++ b/src/PYPinyinObserver.h
@@ -31,13 +31,13 @@ class PinyinObserver : public PyZy::InputContext::Observer {
 public:
     explicit PinyinObserver (PhoneticEditor &editor);
 
-    virtual void commitText (const PyZy::InputContext * context,
+    virtual void commitText (PyZy::InputContext * context,
                              const std::string &commit_text);
-    virtual void inputTextChanged (const PyZy::InputContext * context);
-    virtual void cursorChanged (const PyZy::InputContext * context);
-    virtual void preeditTextChanged (const PyZy::InputContext * context);
-    virtual void auxiliaryTextChanged (const PyZy::InputContext * context);
-    virtual void candidatesChanged (const PyZy::InputContext * context);
+    virtual void inputTextChanged (PyZy::InputContext * context);
+    virtual void cursorChanged (PyZy::InputContext * context);
+    virtual void preeditTextChanged (PyZy::InputContext * context);
+    virtual void auxiliaryTextChanged (PyZy::InputContext * context);
+    virtual void candidatesChanged (PyZy::InputContext * context);
 
 private:
     PhoneticEditor &m_editor;
----- end of patch -----

Peng

On 2012/08/01 08:30:27, hsumita1 wrote: > On 2012/08/01 08:01:19, hsumita1 wrote: > > Hi Peng ...

11 years, 9 months ago (2012-08-01 20:59:59 UTC) #4

On 2012/08/01 08:30:27, hsumita1 wrote:
> On 2012/08/01 08:01:19, hsumita1 wrote:
> 
> Hi Peng
> Could you support this patch on ibus-pinyin?
> I don't know how to send a patch to pyzy branch of ibus-pinyin using git-cl.
> 
> ----- patch for ibus-pinyin -----
> 
> commit 489724cfe920d4eb5d2b96a0698b1b3a10973177
> Author: Hiroshi Sumita <mailto:hsumita@chromium.org>
> Date:   Wed Aug 1 17:19:57 2012 +0900
> 
>     Support pyzy 0.0.9
> 
> diff --git a/src/PYPinyinObserver.cc b/src/PYPinyinObserver.cc
> index 89add3f..2088a0e 100644
> --- a/src/PYPinyinObserver.cc
> +++ b/src/PYPinyinObserver.cc
> @@ -32,33 +32,33 @@ PinyinObserver::PinyinObserver (PhoneticEditor &editor)
>  }
>  
>  void
> -PinyinObserver::commitText (const PyZy::InputContext * context,
> +PinyinObserver::commitText (PyZy::InputContext * context,
>                              const std::string &commit_text)
>  {
>      m_editor.commitCallback (String(commit_text));
>  }
>  
> -void PinyinObserver::inputTextChanged (const PyZy::InputContext * context)
> +void PinyinObserver::inputTextChanged (PyZy::InputContext * context)
>  {
>      m_editor.updateInputText ();
>  }
>  
> -void PinyinObserver::cursorChanged (const PyZy::InputContext * context)
> +void PinyinObserver::cursorChanged (PyZy::InputContext * context)
>  {
>      m_editor.updateCursor ();
>  }
>  
> -void PinyinObserver::preeditTextChanged (const PyZy::InputContext * context)
> +void PinyinObserver::preeditTextChanged (PyZy::InputContext * context)
>  {
>      m_editor.updatePreeditText ();
>  }
>  
> -void PinyinObserver::auxiliaryTextChanged (const PyZy::InputContext *
context)
> +void PinyinObserver::auxiliaryTextChanged (PyZy::InputContext * context)
>  {
>      m_editor.updateAuxiliaryText ();
>  }
>  
> -void PinyinObserver::candidatesChanged (const PyZy::InputContext * context)
> +void PinyinObserver::candidatesChanged (PyZy::InputContext * context)
>  {
>      m_editor.updateLookupTable ();
>  }
> diff --git a/src/PYPinyinObserver.h b/src/PYPinyinObserver.h
> index 80c054d..00116b6 100644
> --- a/src/PYPinyinObserver.h
> +++ b/src/PYPinyinObserver.h
> @@ -31,13 +31,13 @@ class PinyinObserver : public PyZy::InputContext::Observer
{
>  public:
>      explicit PinyinObserver (PhoneticEditor &editor);
>  
> -    virtual void commitText (const PyZy::InputContext * context,
> +    virtual void commitText (PyZy::InputContext * context,
>                               const std::string &commit_text);
> -    virtual void inputTextChanged (const PyZy::InputContext * context);
> -    virtual void cursorChanged (const PyZy::InputContext * context);
> -    virtual void preeditTextChanged (const PyZy::InputContext * context);
> -    virtual void auxiliaryTextChanged (const PyZy::InputContext * context);
> -    virtual void candidatesChanged (const PyZy::InputContext * context);
> +    virtual void inputTextChanged (PyZy::InputContext * context);
> +    virtual void cursorChanged (PyZy::InputContext * context);
> +    virtual void preeditTextChanged (PyZy::InputContext * context);
> +    virtual void auxiliaryTextChanged (PyZy::InputContext * context);
> +    virtual void candidatesChanged (PyZy::InputContext * context);
>  
>  private:
>      PhoneticEditor &m_editor;
> ----- end of patch -----

Sure. Could you please create a CL for it. Thanks

Peng

11 years, 9 months ago (2012-08-01 21:00:06 UTC) #5

https://codereview.appspot.com/6448092/diff/6002/docs/mainpage.txt
File docs/mainpage.txt (right):

https://codereview.appspot.com/6448092/diff/6002/docs/mainpage.txt#newcode14
docs/mainpage.txt:14: void commitText (PyZy::InputContext *context, const
std::string &commit_text) {
This line is too long

Expand All Messages | Collapse All Messages