Issue 6448046: Add a method reporting used font cache size to the SkGraphics API.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6448046: Add a method reporting used font cache size to the SkGraphics API.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by alf

Modified:
12 years, 2 months ago

Reviewers:
robertphillips, reed1

CC:
loislo, Yury Semikhatsky

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add a method reporting used font cache size to the SkGraphics API.

Patch Set 2 : Addressing comments #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	include/core/SkGraphics.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/core/SkGlyphCache.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

alf

Hi folks, We need this change for the WebKit/chromium native memory usage instrumentation effort.

12 years, 2 months ago (2012-07-25 18:19:25 UTC) #1

reed1

lgtm w/ a name change https://codereview.appspot.com/6448046/diff/1/include/core/SkGraphics.h File include/core/SkGraphics.h (right): https://codereview.appspot.com/6448046/diff/1/include/core/SkGraphics.h#newcode53 include/core/SkGraphics.h:53: */ To better mirror ...

12 years, 2 months ago (2012-07-25 18:45:25 UTC) #2

alf

12 years, 2 months ago (2012-07-25 19:52:48 UTC) #3

Could you please land it for me. Thanks!

https://codereview.appspot.com/6448046/diff/1/include/core/SkGraphics.h
File include/core/SkGraphics.h (right):

https://codereview.appspot.com/6448046/diff/1/include/core/SkGraphics.h#newco...
include/core/SkGraphics.h:53: */
On 2012/07/25 18:45:25, reed1 wrote:
> To better mirror GetFontCacheLimit(), how about GetFontCacheUsed()
Sure

Expand All Messages | Collapse All Messages