Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2209)

Issue 6447077: Moved the ownership of the current clip and current matrix into the debug canvas as part of the upc… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by chudy
Modified:
11 years, 10 months ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Moved the ownership of the current clip and current matrix into the debug canvas as part of the upcoming general refactor to everything living in debug canvas. Committed: https://code.google.com/p/skia/source/detail?r=4950

Patch Set 1 #

Patch Set 2 : Implemented signals and slots. Fully functional now. #

Total comments: 4

Patch Set 3 : Fixed moc.sh #

Patch Set 4 : Fixed my first comment about line > 80 chars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -46 lines) Patch
M debugger/QT/SkCanvasWidget.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M debugger/QT/SkCanvasWidget.cpp View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M debugger/QT/SkDebuggerGUI.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.cpp View 1 3 chunks +6 lines, -2 lines 0 comments Download
M debugger/QT/SkGLWidget.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M debugger/QT/SkGLWidget.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M debugger/QT/SkRasterWidget.h View 1 4 chunks +4 lines, -11 lines 0 comments Download
M debugger/QT/SkRasterWidget.cpp View 1 2 chunks +1 line, -4 lines 0 comments Download
M debugger/QT/moc_SkDebuggerGUI.cpp View 1 5 chunks +26 lines, -24 lines 0 comments Download
A debugger/QT/moc_SkGLWidget.cpp View 1 1 chunk +85 lines, -0 lines 0 comments Download
A debugger/QT/moc_SkRasterWidget.cpp View 1 1 chunk +85 lines, -0 lines 0 comments Download
M debugger/SkDebugCanvas.h View 2 chunks +16 lines, -0 lines 0 comments Download
M debugger/SkDebugCanvas.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M debugger/moc.sh View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gyp/debugger.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
chudy
First iteration. Still need to create signals / slots in SkRasterWidget and SkGLWidget that trigger ...
11 years, 11 months ago (2012-08-01 18:30:59 UTC) #1
chudy
Hooked up the proper signals and slots. Everything works.
11 years, 11 months ago (2012-08-01 19:00:21 UTC) #2
chudy
https://codereview.appspot.com/6447077/diff/3001/debugger/QT/SkCanvasWidget.cpp File debugger/QT/SkCanvasWidget.cpp (right): https://codereview.appspot.com/6447077/diff/3001/debugger/QT/SkCanvasWidget.cpp#newcode33 debugger/QT/SkCanvasWidget.cpp:33: connect(&fRasterWidget, SIGNAL(drawComplete()), this->parentWidget(), SLOT(drawComplete())); break into 2 lines
11 years, 11 months ago (2012-08-01 19:04:06 UTC) #3
DerekS
https://codereview.appspot.com/6447077/diff/3001/debugger/moc.sh File debugger/moc.sh (right): https://codereview.appspot.com/6447077/diff/3001/debugger/moc.sh#newcode12 debugger/moc.sh:12: #$MOC $SRC_DIR/SkSettingsWidget.h -o $SRC_DIR/moc_SkSettingsWidget.cpp why are these commented out?
11 years, 11 months ago (2012-08-01 20:01:52 UTC) #4
chudy
https://codereview.appspot.com/6447077/diff/3001/debugger/QT/SkCanvasWidget.cpp File debugger/QT/SkCanvasWidget.cpp (right): https://codereview.appspot.com/6447077/diff/3001/debugger/QT/SkCanvasWidget.cpp#newcode33 debugger/QT/SkCanvasWidget.cpp:33: connect(&fRasterWidget, SIGNAL(drawComplete()), this->parentWidget(), SLOT(drawComplete())); On 2012/08/01 19:04:06, chudy wrote: ...
11 years, 11 months ago (2012-08-01 20:15:37 UTC) #5
DerekS
On 2012/08/01 20:15:37, chudy wrote: > https://codereview.appspot.com/6447077/diff/3001/debugger/QT/SkCanvasWidget.cpp > File debugger/QT/SkCanvasWidget.cpp (right): > > https://codereview.appspot.com/6447077/diff/3001/debugger/QT/SkCanvasWidget.cpp#newcode33 > ...
11 years, 10 months ago (2012-08-03 17:30:56 UTC) #6
chudy
11 years, 10 months ago (2012-08-03 17:33:08 UTC) #7
Verbal lgtm, committed as revision 4950. Thanks for the review
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b