Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(652)

Issue 6447055: In SkGPipe, only serialize SkTypefaces in cross process mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by Leon
Modified:
12 years, 4 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

In SkGPipe, only serialize SkTypefaces in cross process mode. Also make SkGPipeController ref the recording canvas to ensure that objects used by SkGPipeCanvas (e.g. SharedHeap and fTypefaceSet, which hold references to objects to which pointers are written to the stream) survive to be played back even if SkGPipeWriter.endRecording() is called. BUG= TEST=TypefaceGM Committed: https://code.google.com/p/skia/source/detail?r=4817

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -13 lines) Patch
A gm/typeface.cpp View 1 chunk +83 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/pipe/SkGPipe.h View 3 chunks +13 lines, -3 lines 1 comment Download
M src/pipe/SkGPipePriv.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 3 chunks +30 lines, -7 lines 0 comments Download

Messages

Total messages: 2
Leon
12 years, 4 months ago (2012-07-27 20:19:17 UTC) #1
reed1
12 years, 4 months ago (2012-07-27 20:35:54 UTC) #2
lgtm

https://codereview.appspot.com/6447055/diff/1/include/pipe/SkGPipe.h
File include/pipe/SkGPipe.h (right):

https://codereview.appspot.com/6447055/diff/1/include/pipe/SkGPipe.h#newcode76
include/pipe/SkGPipe.h:76: virtual int numberOfReaders() const { return 1; }
LF
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b