Issue 6447055: In SkGPipe, only serialize SkTypefaces in cross process mode.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6447055: In SkGPipe, only serialize SkTypefaces in cross process mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by Leon

Modified:
11 years, 10 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

In SkGPipe, only serialize SkTypefaces in cross process mode. Also make SkGPipeController ref the recording canvas to ensure that objects used by SkGPipeCanvas (e.g. SharedHeap and fTypefaceSet, which hold references to objects to which pointers are written to the stream) survive to be played back even if SkGPipeWriter.endRecording() is called. BUG= TEST=TypefaceGM Committed: https://code.google.com/p/skia/source/detail?r=4817

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+142 lines, -13 lines)			Patch
A	gm/typeface.cpp	View	1 chunk	+83 lines, -0 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/pipe/SkGPipe.h	View	3 chunks	+13 lines, -3 lines	1 comment	Download
M	src/pipe/SkGPipePriv.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pipe/SkGPipeRead.cpp	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	src/pipe/SkGPipeWrite.cpp	View	3 chunks	+30 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

11 years, 10 months ago (2012-07-27 20:35:54 UTC) #2

lgtm

https://codereview.appspot.com/6447055/diff/1/include/pipe/SkGPipe.h
File include/pipe/SkGPipe.h (right):

https://codereview.appspot.com/6447055/diff/1/include/pipe/SkGPipe.h#newcode76
include/pipe/SkGPipe.h:76: virtual int numberOfReaders() const { return 1; }
LF

Expand All Messages | Collapse All Messages