Issue 6446164: Benchmark results will now print to STDOUT if on not-Android.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6446164: Benchmark results will now print to STDOUT if on not-Android. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by keyar

Modified:
12 years ago

Reviewers:
junov1

CC:
skia-review_googlegroups.com, benchen

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Benchmark results will now print to STDOUT if on not-Android. Committed https://code.google.com/p/skia/source/detail?r=5215

Patch Set 2 : #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -20 lines)			Patch
M	tools/PictureBenchmark.cpp	View		5 chunks	+25 lines, -17 lines	0 comments	Download
M	tools/bench_pictures_main.cpp	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	tools/picture_utils.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/picture_utils.cpp	View	1	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

junov1

https://codereview.appspot.com/6446164/diff/1/tools/picture_utils.h File tools/picture_utils.h (right): https://codereview.appspot.com/6446164/diff/1/tools/picture_utils.h#newcode31 tools/picture_utils.h:31: // Prints to STDOUT if not on Android. Prints ...

12 years ago (2012-08-21 17:06:24 UTC) #2

junov1

12 years ago (2012-08-21 17:38:41 UTC) #4

On 2012/08/21 17:33:28, keyar wrote:
> Fixed up comments as requested.

lgtm

Expand All Messages | Collapse All Messages