Issue 6446103: split out src file names into core.gypi, with an eye towards sharing that

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6446103: split out src file names into core.gypi, with an eye towards sharing that (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by reed1

Modified:
12 years, 3 months ago

Reviewers:
epoger, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

split out src file names into core.gypi, with an eye towards sharing that file with chrome... Committed: https://code.google.com/p/skia/source/detail?r=5007

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+266 lines, -241 lines)			Patch
M	gyp/common_variables.gypi	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	gyp/core.gyp	View	1	1 chunk	+3 lines, -241 lines	1 comment	Download
A	gyp/core.gypi	View	1	1 chunk	+258 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

12 years, 3 months ago (2012-08-08 20:42:48 UTC) #4

https://codereview.appspot.com/6446103/diff/5001/gyp/core.gyp
File gyp/core.gyp (left):

https://codereview.appspot.com/6446103/diff/5001/gyp/core.gyp#oldcode323
gyp/core.gyp:323: '../src/core/SkUtilsArm.cpp',
These (and srcs in other conditions blocks) should probably be moved to gypi and
these conditional includes changed to conditional excludes.

Expand All Messages | Collapse All Messages