Issue 6445088: Replaced all instances of std strings and vectors in favor of SkStrings and SkTDArrays within skia …

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6445088: Replaced all instances of std strings and vectors in favor of SkStrings and SkTDArrays within skia … (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by chudy

Modified:
12 years, 4 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Replaced all instances of std strings and vectors in favor of SkStrings and SkTDArrays within skia code Committed: https://code.google.com/p/skia/source/detail?r=4995

Patch Set 1 : #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+246 lines, -269 lines)			Patch
M	debugger/QT/SkDebuggerGUI.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View	4 chunks	+15 lines, -15 lines	0 comments	Download
M	debugger/SkDebugCanvas.h	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	debugger/SkDebugCanvas.cpp	View	4 chunks	+20 lines, -23 lines	0 comments	Download
M	debugger/SkDebugger.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	debugger/SkDrawCommand.h	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	debugger/SkDrawCommand.cpp	View	30 chunks	+68 lines, -73 lines	0 comments	Download
M	debugger/SkObjectParser.h	View	4 chunks	+21 lines, -17 lines	0 comments	Download
M	debugger/SkObjectParser.cpp	View	1 chunk	+108 lines, -123 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DerekS

rubber stamped lgtm. You should probably run valgrind on this to make sure you didn't ...

12 years, 4 months ago (2012-08-07 20:35:09 UTC) #2

Committed in revision 4995. Thanks for the review

Expand All Messages | Collapse All Messages