Issue 6443149: peephole optimize save/restore brackets that contain no draw calls.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6443149: peephole optimize save/restore brackets that contain no draw calls. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by reed1

Modified:
12 years, 2 months ago

Reviewers:
DerekS, Leon, bsalomon, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

peephole optimize save/restore brackets that contain no draw calls. Committed: https://code.google.com/p/skia/source/detail?r=5347

Patch Set 7 : #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -12 lines)			Patch
M	src/core/SkPictureFlat.h	View	1 2 3 4 5	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/core/SkPictureRecord.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkPictureRecord.cpp	View	1 2 3 4 5	4 chunks	+115 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

Could be two sequential CLs 1. add rewind api to SkWriter32 2. use that to ...

12 years, 2 months ago (2012-08-17 18:09:09 UTC) #1

robertphillips

LGTM + 1 nit. https://codereview.appspot.com/6443149/diff/2001/src/core/SkPictureRecord.cpp File src/core/SkPictureRecord.cpp (right): https://codereview.appspot.com/6443149/diff/2001/src/core/SkPictureRecord.cpp#newcode143 src/core/SkPictureRecord.cpp:143: collaps -> collapse everywhere?

12 years, 2 months ago (2012-08-28 17:09:24 UTC) #2

Leon

https://codereview.appspot.com/6443149/diff/2001/src/core/SkPictureRecord.cpp File src/core/SkPictureRecord.cpp (right): https://codereview.appspot.com/6443149/diff/2001/src/core/SkPictureRecord.cpp#newcode60 src/core/SkPictureRecord.cpp:60: fRestoreOffsetStack.push(-(int32_t)fWriter.size()); What happens if save is the first draw ...

12 years, 2 months ago (2012-08-28 17:10:38 UTC) #3

reed1

12 years, 2 months ago (2012-08-28 20:07:46 UTC) #4

https://codereview.appspot.com/6443149/diff/2001/src/core/SkPictureRecord.cpp
File src/core/SkPictureRecord.cpp (right):

https://codereview.appspot.com/6443149/diff/2001/src/core/SkPictureRecord.cpp...
src/core/SkPictureRecord.cpp:60:
fRestoreOffsetStack.push(-(int32_t)fWriter.size());
On 2012/08/28 17:10:38, scroggo-work wrote:
> What happens if save is the first draw command recorded? Will we still
recognize
> this as a save rather than a clip entry?

We just have to be non-positive. I have updated the comment to that effect.

Expand All Messages | Collapse All Messages