Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(294)

Issue 6443089: Add README.chromium for license information regarding Android SDK/NDK. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by navabi1
Modified:
13 years, 2 months ago
Reviewers:
cmp, open-source-third-party-reviews, yfriedman, Steve Block, mnaganov
Base URL:
ssh://gerrit.chromium.org:29418/android_tools.git@master
Visibility:
Public.

Description

Add README.chromium for license information regarding Android SDK/NDK. BUG= An equivalent change has been pushed to the android_tools repo. This patch is no longer necessary. Closing.

Patch Set 1 #

Patch Set 2 : Added COPYING.txt license file and pointed to in README.chromium. #

Patch Set 3 : Add Notice for all files in directory. #

Patch Set 4 : Fix whitespace nits. #

Total comments: 1

Patch Set 5 : Change license file name and add android compatible line to readme. #

Total comments: 2

Patch Set 6 : Remove License Android Compatible line from readme. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -9 lines) Patch
A + LICENSE View 1 2 3 4 2 chunks +32 lines, -9 lines 0 comments Download
A README.chromium View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13
navabi1
13 years, 3 months ago (2012-08-06 18:56:10 UTC) #1
Steve Block
Thanks! lgtm
13 years, 2 months ago (2012-08-07 09:59:45 UTC) #2
Steve Block
Sorry, I take that back. Did you run 'tools/licenses.py scan'? It looks like there's no ...
13 years, 2 months ago (2012-08-07 10:04:01 UTC) #3
navabi1
On 2012/08/07 10:04:01, Steve Block wrote: > Sorry, I take that back. > > Did ...
13 years, 2 months ago (2012-08-08 23:27:31 UTC) #4
navabi1
Nevermind. I was running ". tools/licenses.py scan", which gave me the error. Before this patch: ...
13 years, 2 months ago (2012-08-08 23:30:10 UTC) #5
Steve Block
lgtm https://codereview.appspot.com/6443089/diff/8001/README.chromium File README.chromium (right): https://codereview.appspot.com/6443089/diff/8001/README.chromium#newcode6 README.chromium:6: License File: COPYING.txt Unless you have a particular ...
13 years, 2 months ago (2012-08-09 10:00:34 UTC) #6
navabi1
https://codereview.appspot.com/6443089/diff/2002/README.chromium File README.chromium (right): https://codereview.appspot.com/6443089/diff/2002/README.chromium#newcode6 README.chromium:6: License Android Compatibile: yes steveblock. im assuming this was ...
13 years, 2 months ago (2012-08-15 02:40:38 UTC) #7
Steve Block
https://codereview.appspot.com/6443089/diff/2002/README.chromium File README.chromium (right): https://codereview.appspot.com/6443089/diff/2002/README.chromium#newcode6 README.chromium:6: License Android Compatibile: yes No, I was talking about ...
13 years, 2 months ago (2012-08-15 09:31:36 UTC) #8
navabi1
13 years, 2 months ago (2012-08-15 16:20:38 UTC) #9
Steve Block
lgtm
13 years, 2 months ago (2012-08-15 16:22:29 UTC) #10
mnaganov
On 2012/08/15 16:22:29, Steve Block wrote: > lgtm Armand, do you plan to proceed with ...
13 years, 2 months ago (2012-08-21 11:04:19 UTC) #11
navabi1
13 years, 2 months ago (2012-08-21 18:42:56 UTC) #12
navabi1
13 years, 2 months ago (2012-08-21 18:43:10 UTC) #13
An equivalent change has been pushed to the android_tools repo.  This patch is
no longer necessary. Closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b