Issue 6443076: render_pictures and bench_pictures now use a --mode parameter.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6443076: render_pictures and bench_pictures now use a --mode parameter. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by keyar

Modified:
12 years, 4 months ago

Reviewers:
junov1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

render_pictures and bench_pictures now use a --mode parameter. This replaces the --tile, --pipe, etc. options from before as they are mutually exclusive. Committed https://code.google.com/p/skia/source/detail?r=4930

Patch Set 1 : #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : Help fixes. #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -67 lines)			Patch
	M	tools/bench_pictures_main.cpp	View	1 2	3 chunks	+63 lines, -41 lines	0 comments	Download
	M	tools/render_pictures_main.cpp	View	1 2	2 chunks	+52 lines, -26 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

junov1

12 years, 4 months ago (2012-08-02 15:40:33 UTC) #2

lgtm with minor corrections

https://codereview.appspot.com/6443076/diff/6001/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (right):

https://codereview.appspot.com/6443076/diff/6001/tools/bench_pictures_main.cp...
tools/bench_pictures_main.cpp:40: "                     tile width[%] height[%],
Benchmark rendering tiles with\n"
Is the tiling done with pipe, picture, simple?

https://codereview.appspot.com/6443076/diff/6001/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6443076/diff/6001/tools/render_pictures_main.c...
tools/render_pictures_main.cpp:26: "     [--mode pipe|simple| tile width[%]
height[%]]"
spaces around |

https://codereview.appspot.com/6443076/diff/6001/tools/render_pictures_main.c...
tools/render_pictures_main.cpp:42: "                     tile width[%]
height[%], Render using tiles with the given\n"
Same comment: tile uses what?

Expand All Messages | Collapse All Messages